feat: added max_time_sereis and max_samples in prom queries #6802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added MaxTimeSeries, MaxSamples to limit prom queries.
we have set these values in context so that it can be picked while adding clickhouse settings.
Related Issues / PR's
https://github.com/SigNoz/engineering-pod/issues/1996
Important
Add
MaxTimeSeries
andMaxSamples
toPromQuery
and update context handling inquerier.go
to enforce query limits.MaxTimeSeries
andMaxSamples
fields toPromQuery
inv3.go
to limit Prometheus queries.runPromQueries()
inquerier.go
to includeMaxTimeSeries
andMaxSamples
settings.ResultOverflowMode
,MaxRowsToGroupBy
, andMaxResultRows
toconstants.go
for context settings.execPromQuery()
calls inquerier.go
to use modified context with limits.This description was created by for e67a024. It will automatically update as commits are pushed.