Configure service modal

[ahmadshaheer]

Summary

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

---

Important

Add ConfigureServiceModal for AWS service settings, update related API and UI components.

• New Features:
  • Add ConfigureServiceModal component in ConfigureServiceModal.tsx for configuring AWS service settings.
  • Introduce updateServiceConfig function in index.ts for updating service configurations.
  • Add useUpdateServiceConfig hook in useUpdateServiceConfig.ts for handling service configuration updates.
• UI Changes:
  • Replace loading text with Spinner component in ServiceDetails.tsx and ServicesList.tsx.
  • Add styles for ConfigureServiceModal in ConfigureServiceModal.styles.scss.
• Refactoring:
  • Remove unused useRef in RegionForm.tsx and adjust refetchInterval.
  • Remove hardcoded service data from data.ts.
• Types:
  • Add UpdateServiceConfigPayload and UpdateServiceConfigResponse types in types.ts.

^{This description was created by for 2d3a61b. It will automatically update as commits are pushed.}

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 2d3a61b in 1 minute and 7 seconds

More details

• Looked at 780 lines of code in 10 files
• Skipped 0 files when reviewing.
• Skipped posting 7 drafted comments based on config settings.

1. frontend/src/container/CloudIntegrationPage/HeroSection/components/components/RegionForm.tsx:40

• Draft comment:
  Consider defining refetchInterval as a constant for better maintainability, as it is used in multiple places.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The refetchInterval is hardcoded in multiple places. It would be better to define it as a constant for maintainability.

2. frontend/src/container/CloudIntegrationPage/ServicesSection/ConfigureServiceModal.tsx:94

• Draft comment:
  The isSaveDisabled logic should check if the current values differ from the initial configuration to enable saving.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The current logic makes sense - if both metrics and logs are disabled, there's nothing to save. Comparing against initial values would prevent saving when no changes were made, but that's not necessarily bad UX - users might want to review and save current settings even if unchanged. The current approach is simpler and clearer.
  The comment has a point - allowing saves when no changes were made could be considered inefficient. It could trigger unnecessary API calls.
  While preventing unchanged saves could optimize API calls, it adds complexity for minimal benefit. The current approach is more intuitive - if at least one service is enabled, you can save.
  The current implementation is reasonable and simple. The suggested change would add complexity without significant benefit.

3. frontend/src/container/CloudIntegrationPage/ServicesSection/ConfigureServiceModal.tsx:123

• Draft comment:
  Remove the extra space in rootClassName to avoid potential styling issues.

			rootClassName="configure-service-modal"

• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  While having an extra space in a className could potentially cause styling issues, the fact that this pattern is repeated elsewhere in the file (line 133) suggests it might be intentional. Without seeing the CSS files and understanding the styling system, we can't be certain this would cause any real problems. The build system would likely handle this fine either way.
  I might be underestimating the impact of extra spaces in class names. Also, even if it works, it could still be considered a code quality issue worth fixing.
  While code cleanliness is important, this seems like a very minor issue that doesn't clearly cause any problems, and the consistency of the pattern suggests it might be intentional.
  Delete the comment as it's not clearly identifying a real problem, and the extra space might be intentional given its consistent usage in the file.

4. frontend/src/container/CloudIntegrationPage/HeroSection/components/components/RegionForm.tsx:34

• Draft comment:
  Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This is also applicable on line 143.
• Reason this comment was not posted:
  Comment was on unchanged code.

5. frontend/src/container/CloudIntegrationPage/ServicesSection/ConfigureServiceModal.styles.scss:6

• Draft comment:
  Use design tokens or predefined color constants instead of hardcoding color values to maintain consistency in design and theming. This is also applicable on lines 15 and 25.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

6. frontend/src/container/CloudIntegrationPage/ServicesSection/ConfigureServiceModal.styles.scss:15

• Draft comment:
  Use design tokens or predefined color constants instead of hardcoding color values to maintain consistency in design and theming. This is also applicable on lines 6 and 25.
• Reason this comment was not posted:
  Marked as duplicate.

7. frontend/src/container/CloudIntegrationPage/ServicesSection/ConfigureServiceModal.styles.scss:25

• Draft comment:
  Use design tokens or predefined color constants instead of hardcoding color values to maintain consistency in design and theming. This is also applicable on lines 6 and 15.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_zsCFHp3XEwQnu9DF

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Remove the console.log statement to clean up the code.

Suggested change

console.log({ serviceId });