Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode support and overall improvements to AWS integration page #6817

Open
wants to merge 9 commits into
base: configure-service-modal
Choose a base branch
from

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Jan 14, 2025

Summary

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Add light mode support and enhance AWS integration page with improved styles, components, and hooks.

  • Light Mode Support:
    • Added light mode styles to SignozModal.style.scss, CloudIntegrationPage.style.scss, Header.styles.scss, HeroSection.style.scss, AccountActions.style.scss, AccountSettingsModal.style.scss, CloudAccountSetupModal.style.scss, SuccessView.style.scss, ConfigureServiceModal.styles.scss, ServicesTabs.style.scss.
  • AWS Integration Enhancements:
    • Updated CloudIntegrationPage.tsx to include Header, HeroSection, and ServicesTabs components.
    • Refactored CloudAccountSetupModal.tsx to improve modal configuration and handling of success state.
    • Enhanced RegionForm.tsx to handle region selection and form submission.
    • Improved ServiceDetails.tsx to display service status and configure services.
    • Updated ServicesList.tsx to filter services based on their status.
    • Modified ServicesTabs.tsx to include a filter for services and display service details.
  • React Query Keys:
    • Added AWS-related query keys to reactQueryKeys.ts for better query management.
  • Hooks:
    • Updated hooks in useAccountStatus.ts, useAwsAccounts.ts, useGetAccountServices.ts, useServiceDetails.ts to use new query keys and improve data fetching logic.

This description was created by Ellipsis for 15b5bb4. It will automatically update as commits are pushed.

@ahmadshaheer ahmadshaheer requested a review from YounixM as a code owner January 14, 2025 14:19
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e634a95 in 34 seconds

More details
  • Looked at 986 lines of code in 17 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/hooks/integrations/aws/useGetAccountServices.ts:2
  • Draft comment:
    Ensure that the import path for Service is correct after the file restructuring. The path should reflect the new location of the types file.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The import path for the Service type was updated to reflect the new location of the types file. This change is correct and necessary due to the file restructuring in the PR.
2. frontend/src/hooks/integrations/aws/useGetAccountServices.ts:2
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_svBhLaeIKLa1U2ka


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 15b5bb4 in 36 seconds

More details
  • Looked at 23 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/container/CloudIntegrationPage/ServicesSection/ServiceDetails.tsx:114
  • Draft comment:
    Ensure markdownContent is sanitized to prevent XSS attacks when using MarkdownRenderer.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. frontend/src/container/CloudIntegrationPage/ServicesSection/ServiceDetails.tsx:109
  • Draft comment:
    Use a design token or predefined color constant instead of hardcoding the color value for the Wrench icon.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_7ncxupbmQXuGACou


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant