-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light mode support and overall improvements to AWS integration page #6817
base: configure-service-modal
Are you sure you want to change the base?
Light mode support and overall improvements to AWS integration page #6817
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to e634a95 in 34 seconds
More details
- Looked at
986
lines of code in17
files - Skipped
1
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/hooks/integrations/aws/useGetAccountServices.ts:2
- Draft comment:
Ensure that the import path forService
is correct after the file restructuring. The path should reflect the new location of thetypes
file. - Reason this comment was not posted:
Confidence changes required:20%
The import path for theService
type was updated to reflect the new location of thetypes
file. This change is correct and necessary due to the file restructuring in the PR.
2. frontend/src/hooks/integrations/aws/useGetAccountServices.ts:2
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_svBhLaeIKLa1U2ka
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 15b5bb4 in 36 seconds
More details
- Looked at
23
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/container/CloudIntegrationPage/ServicesSection/ServiceDetails.tsx:114
- Draft comment:
EnsuremarkdownContent
is sanitized to prevent XSS attacks when usingMarkdownRenderer
. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/src/container/CloudIntegrationPage/ServicesSection/ServiceDetails.tsx:109
- Draft comment:
Use a design token or predefined color constant instead of hardcoding the color value for the Wrench icon. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_7ncxupbmQXuGACou
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Add light mode support and enhance AWS integration page with improved styles, components, and hooks.
SignozModal.style.scss
,CloudIntegrationPage.style.scss
,Header.styles.scss
,HeroSection.style.scss
,AccountActions.style.scss
,AccountSettingsModal.style.scss
,CloudAccountSetupModal.style.scss
,SuccessView.style.scss
,ConfigureServiceModal.styles.scss
,ServicesTabs.style.scss
.CloudIntegrationPage.tsx
to includeHeader
,HeroSection
, andServicesTabs
components.CloudAccountSetupModal.tsx
to improve modal configuration and handling of success state.RegionForm.tsx
to handle region selection and form submission.ServiceDetails.tsx
to display service status and configure services.ServicesList.tsx
to filter services based on their status.ServicesTabs.tsx
to include a filter for services and display service details.reactQueryKeys.ts
for better query management.useAccountStatus.ts
,useAwsAccounts.ts
,useGetAccountServices.ts
,useServiceDetails.ts
to use new query keys and improve data fetching logic.This description was created by for 15b5bb4. It will automatically update as commits are pushed.