Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Enable executing store agents without agent ownership #9267

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jan 14, 2025

This re-introduces PR #9179 with some fixes.

This PR enables the execution of store agents even if they are not owned by the user. Key changes include handling store-listed agents in the get_graph logic, improving execution flow, and ensuring version-specific handling. These updates support more flexible agent execution.

Changes 🏗️

(copied from #9179)

  • Graph Retrieval: Updated get_graph to check store listings for agents not owned by the user.
  • Version Handling: Added graph_version to execution methods for consistent version-specific execution.
  • Execution Flow: Refactored scheduler.py, rest_api.py, and other modules for clearer logic and better maintainability.
  • Testing: Updated test_manager.py and other test cases to validate execution of store-listed agents added test for accessing graph

Out-of-scope changes:

  • Add logic to pretty-print Pydantic validation error responses to backend API client in frontend

ntindle and others added 9 commits January 12, 2025 17:11
Enable the tests in `monitor.spec.ts`.

* Remove `test.describe.skip` to enable the tests.
* Ensure the tests are now running and passing successfully.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Significant-Gravitas/AutoGPT?shareId=XXXX-XXXX-XXXX-XXXX).
…wnership (#9179)

This PR enables the execution of store agents even if they are not owned
by the user. Key changes include handling store-listed agents in the
`get_graph` logic, improving execution flow, and ensuring
version-specific handling. These updates support more flexible agent
execution.

- **Graph Retrieval:** Updated `get_graph` to check store listings for
agents not owned by the user.
- **Version Handling:** Added `graph_version` to execution methods for
consistent version-specific execution.
- **Execution Flow:** Refactored `scheduler.py`, `rest_api.py`, and
other modules for clearer logic and better maintainability.
- **Testing:** Updated `test_manager.py` and other test cases to
validate execution of store-listed agents added test for accessing graph

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Zamil Majdy <[email protected]>
…ts/open-2276-add-ability-to-execute-store-agents-without-agent-ownership
@Pwuts Pwuts requested a review from a team as a code owner January 14, 2025 14:22
@Pwuts Pwuts requested review from Swiftyos and majdyz and removed request for a team January 14, 2025 14:22
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for auto-gpt-docs-dev ready!

Name Link
🔨 Latest commit 42c3f78
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6798b567d4ba370008c5b40a
😎 Deploy Preview https://deploy-preview-9267--auto-gpt-docs-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Jan 14, 2025
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 42c3f78
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6798b5677e9f410008636581
😎 Deploy Preview https://deploy-preview-9267--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pwuts Pwuts force-pushed the pwuts/open-2276-add-ability-to-execute-store-agents-without-agent-ownership branch from af6be24 to 03df229 Compare January 22, 2025 10:35
@github-actions github-actions bot added size/xl and removed size/l labels Jan 26, 2025
@Pwuts Pwuts requested a review from ntindle January 26, 2025 09:12
@github-actions github-actions bot added size/l and removed size/xl labels Jan 26, 2025
ntindle
ntindle previously approved these changes Jan 26, 2025
@Pwuts Pwuts disabled auto-merge January 26, 2025 13:02
@Pwuts

This comment was marked as resolved.

@Pwuts Pwuts enabled auto-merge January 27, 2025 20:37
@Pwuts Pwuts added this pull request to the merge queue Jan 28, 2025
Merged via the queue into dev with commit 0811e8a Jan 28, 2025
24 checks passed
@Pwuts Pwuts deleted the pwuts/open-2276-add-ability-to-execute-store-agents-without-agent-ownership branch January 28, 2025 11:17
waterstark pushed a commit to waterstark/AutoGPT that referenced this pull request Jan 30, 2025
…ignificant-Gravitas#9267)

This re-introduces PR Significant-Gravitas#9179 with some fixes.

This PR enables the execution of store agents even if they are not owned
by the user. Key changes include handling store-listed agents in the
`get_graph` logic, improving execution flow, and ensuring
version-specific handling. These updates support more flexible agent
execution.

### Changes 🏗️
(copied from Significant-Gravitas#9179)

- **Graph Retrieval:** Updated `get_graph` to check store listings for
agents not owned by the user.
- **Version Handling:** Added `graph_version` to execution methods for
consistent version-specific execution.
- **Execution Flow:** Refactored `scheduler.py`, `rest_api.py`, and
other modules for clearer logic and better maintainability.
- **Testing:** Updated `test_manager.py` and other test cases to
validate execution of store-listed agents added test for accessing graph

Out-of-scope changes:
- Add logic to pretty-print Pydantic validation error responses to
backend API client in frontend

---------

Co-authored-by: Nicholas Tindle <[email protected]>
Co-authored-by: Nicholas Tindle <[email protected]>
Co-authored-by: Swifty <[email protected]>
Co-authored-by: Zamil Majdy <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2025
- Blocked by #9267

This re-introduces changes from the following PRs with fixes:
- #9218
- #9211

### Changes 🏗️

- See #9218
- See #9211

Fixes:
- Fix Prisma query statements in `v2.library.db`
- Fix creation of (library) agents
- Fix test cleanup of (library) agents
- Fix handling and passing of `node_input` parameters

### Checklist 📋

#### For code changes:
- [x] I have clearly listed my changes in the PR description
- [x] I have made a test plan
- [x] I have tested my changes according to the test plan:
  - [x] Create & run a new agent
  - [x] Update & run an existing agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/l
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants