SWPROT-8171: Implement CC Device_Reset_Locally #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Zniffer traces included in SWPROT-8171 description, we saw that continuous beams are sent to a previously reset device. Zwave specs: CL:005A.01.52.01.1 A controlling node receiving the Device Reset Locally Notification Command SHOULD consider the sending node to be a failing node and accordingly perform relevant maintenance operations like removing failing nodes, removing associations to failing nodes, etc. CL:005A.01.51.01.1 A controlling node receiving the Device Reset Locally Notification Command MUST indicate to the end user that the node has been reset and left the Z-Wave network. According to that two points, it appears that excluding the reset node is the better solution to avoid this kind of ghost nodes problems. This commit implements the management of DeviceResetLocally command class in ZGW. Implementation has been done to be as close as PC Controller one found at s.s.c/p/Z/r/z/b/S/Z/Z/M/BasicControllerSession.cs#2926 . Origin: ver7_18.03-1-gcb9cc40d Forwarded: SiliconLabs#39 Signed-off-by: Philippe Coval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Zniffer traces included in SWPROT-8171 description, we saw that continuous beams are sent to a previously reset device.
Zwave specs:
CL:005A.01.52.01.1 A controlling node receiving the Device Reset Locally Notification Command SHOULD consider the sending node to be a failing node and accordingly perform relevant maintenance operations like removing failing nodes, removing associations to failing nodes, etc.
CL:005A.01.51.01.1 A controlling node receiving the Device Reset Locally Notification Command MUST indicate to the end user that the node has been reset and left the Z-Wave network.
According to that two points, it appears that excluding the reset node is the better solution to avoid this kind of ghost nodes problems. This commit implements the management of DeviceResetLocally command class in ZGW.
Implementation has been done to be as close as PC Controller one found at
s.s.c/p/Z/r/z/b/S/Z/Z/M/BasicControllerSession.cs#2926 .
TuDao added a 2-second delay before sending NOP to remove the failed nodes.
Origin: ver7_18.03-1-gcb9cc40d
Originnal PR: #39