potential path travesal #1408
Open
potential path travesal #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi all, I have a reviewed of the code and figured the 'thePath' parameter is obtained from the request and used to create a File object without proper validation, potentially allowing user to write files to arbitrary locations on the filesystem. This is my suggest fix. Cheer
Member
|
Hi, thanks for your report. I will have a look on it later. For the moment, we're all busy. |
mmoqui
requested changes
May 19, 2025
| SilverLogger.getLogger("wysiwyg").error("Error during file upload", e); | ||
| %> | ||
| <script language="javascript"> | ||
| alert("<%=WebEncodeHelper.javaStringToJsString(message.getString("Error") + ": " + e.getMessage())%>"); |
Member
There was a problem hiding this comment.
Instead of alert, we have our own way to inform the user by using our popin mechanism. In this case, the alert statement should be replaced by the following one:
sp.popup.error("<%=WebEncodeHelper.javaStringToJsString(message.getString("Error") + ": " + e.getMessage())%>");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I have a reviewed the code and figured the 'thePath' parameter in core-war/src/main/webapp/wysiwyg/jsp/uploadWebsiteFile.jsp is obtained from the request and used to create a File object without validation, potentially allowing a user to write files to arbitrary locations on the filesystem. This is my suggest fix.
Cheer