feat: 🚀 Fixed and improved side event arranger #488
Draft
Sahil-Simform wants to merge 5 commits intomasterfrom
Draft
feat: 🚀 Fixed and improved side event arranger #488Sahil-Simform wants to merge 5 commits intomasterfrom
Sahil-Simform wants to merge 5 commits intomasterfrom
Conversation
Sahil-Simform
force-pushed
the
fix/improved_side_event_arranger
branch
from
8e04870 to
6108c1c
Compare
ami-b-simform
requested review from
ami-b-simform
and removed request for
ami-b-simform
ami-b-simform
force-pushed
the
fix/improved_side_event_arranger
branch
3 times, most recently
from
9e8d101 to
51b571b
Compare
Collaborator
|
Converting this PR to a draft as we need more improvements in the algorythm |
kavantrivedi
force-pushed
the
fix/improved_side_event_arranger
branch
from
51b571b to
21f1c46
Compare
kavantrivedi
force-pushed
the
fix/improved_side_event_arranger
branch
2 times, most recently
from
06cb588 to
7fb3955
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the SideEventArranger class to fix overlapping event issues and improve event arrangement, particularly for scenarios with 4 consecutive events. The implementation replaces the previous recursive algorithm with a cleaner column-based approach.
Key changes:
- Complete rewrite of the event arrangement algorithm using a first-fit column allocation strategy
- Renamed
includeEdgesparameter tocountAdjacentEventsAsOverlappingfor better clarity - Added comprehensive documentation for all methods with edge case descriptions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kavantrivedi
force-pushed
the
fix/improved_side_event_arranger
branch
from
7fb3955 to
a6e9913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues