chore: prevent delay inkwell if doubleTap undefined#496
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a performance issue where InkWell and GestureDetector widgets experience unnecessary delays when the double-tap callback is undefined. The fix ensures that tap handlers are only assigned when their corresponding callbacks are non-null, preventing Flutter's gesture disambiguation delay.
Key Changes:
- Modified event tap handlers to conditionally assign callbacks based on null checks
- Applied the fix to both InkWell and GestureDetector components consistently
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/src/components/day_view_components.dart |
Updated InkWell tap handlers (onTap, onLongPress, onDoubleTap) to use null checks before assignment |
lib/src/components/_internal_components.dart |
Updated GestureDetector tap handlers (onTap, onLongPress, onDoubleTap) to use null checks before assignment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Prevent delay inkwell if doubleTap undefined
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Evidences
Bug
bug.mov
Fix
fixed.mov