Skip to content

chore: prevent delay inkwell if doubleTap undefined#496

Merged
PRBaraiya merged 2 commits intoSimformSolutionsPvtLtd:masterfrom
ReniDelonzek:chore/prevent-delay-inkwell
Jan 5, 2026
Merged

chore: prevent delay inkwell if doubleTap undefined#496
PRBaraiya merged 2 commits intoSimformSolutionsPvtLtd:masterfrom
ReniDelonzek:chore/prevent-delay-inkwell

Conversation

@ReniDelonzek
Copy link
Contributor

Description

Prevent delay inkwell if doubleTap undefined

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Evidences

Bug

bug.mov

Fix

fixed.mov

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a performance issue where InkWell and GestureDetector widgets experience unnecessary delays when the double-tap callback is undefined. The fix ensures that tap handlers are only assigned when their corresponding callbacks are non-null, preventing Flutter's gesture disambiguation delay.

Key Changes:

  • Modified event tap handlers to conditionally assign callbacks based on null checks
  • Applied the fix to both InkWell and GestureDetector components consistently

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/src/components/day_view_components.dart Updated InkWell tap handlers (onTap, onLongPress, onDoubleTap) to use null checks before assignment
lib/src/components/_internal_components.dart Updated GestureDetector tap handlers (onTap, onLongPress, onDoubleTap) to use null checks before assignment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PRBaraiya PRBaraiya merged commit eb963e1 into SimformSolutionsPvtLtd:master Jan 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants