test: 🧪 Added tests for Overlay #549
Conversation
Sahil-Simform
force-pushed
the
testing/overlay_tests
branch
2 times, most recently
from
860c94b to
aa84c53
Compare
Sahil-Simform
force-pushed
the
testing/overlay_tests
branch
from
aa84c53 to
6b366eb
Compare
There was a problem hiding this comment.
- Additional Note -
Please cover following cases:
- Showcaseview properties applied correctly to the overlay
- Only the properties of first showcase is used for the overlay in case of simultaneously showing multiple showcases
- The overlay has correct rect cutouts for the target widget
lib/src/utils/extensions.dart
Outdated
| Color reduceOpacity(double opacity) => withAlpha((opacity * 255).round()); | ||
|
|
||
| /// Safe replacement for deprecated red property | ||
| int get safeRed => (0x00ff0000 & _toARGB32()) >> 16; |
There was a problem hiding this comment.
Please mention the reason behind creating this method. In which flutter version did the property got deprecated and in what flutter version it would be safe to remove this and use inbuilt way.
|
|
||
| double? findOverlayBlurSigma(WidgetTester tester) { | ||
| final filters = | ||
| tester.widgetList(find.byType(ImageFiltered)).cast<ImageFiltered?>(); |
There was a problem hiding this comment.
Please use the generic type of widgetList instead of casting.
|
|
||
| final match = RegExp(r'ImageFilter\.blur\(\s*([0-9.]+)\s*,\s*([0-9.]+)') | ||
| .firstMatch(str); | ||
| if (match != null) { |
| setUp( | ||
| () { | ||
| ShowcaseView.register(); | ||
| }, | ||
| ); | ||
| tearDown( | ||
| () { | ||
| ShowcaseView.get().unregister(); | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Please leverage tear off.
| ); | ||
|
|
||
| testWidgets( | ||
| 'Overlay renders with default properties', |
There was a problem hiding this comment.
The test and description doesn't match. No overlay properties are checked for default value.
| expect(find.byType(Overlay), findsWidgets); | ||
|
|
||
| // Explicitly ask to rebuild the overlay | ||
| ShowcaseView.get().updateOverlay(); |
There was a problem hiding this comment.
This shouldn't be required.
| }, | ||
| ); | ||
|
|
||
| testWidgets('Overlay with custom target shape borders', |
There was a problem hiding this comment.
The test and the description doesn't match. The border applied is not checked.
| expect(find.byType(Overlay), findsWidgets); | ||
| }); | ||
|
|
||
| testWidgets('Overlay with zero opacity', (WidgetTester tester) async { |
There was a problem hiding this comment.
You can combine this with different opacities tests.
| expect(color, Colors.black.reduceOpacity(0.0)); | ||
| }); | ||
|
|
||
| testWidgets('Overlay with full opacity', (WidgetTester tester) async { |
There was a problem hiding this comment.
This can be combined as well as mentioned for the above test.
| }); | ||
| }); | ||
|
|
||
| group('Overlay Edge Cases', () { |
There was a problem hiding this comment.
All of the tests in this group can be combined with the test in the above group.
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues