Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake #13

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Cmake #13

merged 12 commits into from
Feb 21, 2024

Conversation

ErniBrown
Copy link
Contributor

Hi!
I worked on a version more cmake oriented, using the exported targets functionalities. I also added a sketch for cpack, it can be used to generate a deb package, in case you want to add it to canonical ;)

@SimonCahill
Copy link
Owner

Thanks for the contribution! Much appreciated!

I honestly didn't think it'd be of use to anyone in the package sources, but it seems as though there is a use for it :)
I'll take a gander on how to add it.

One thing I've noticed, is that it doesn't generate a .deb package, rather a series of tar-files. But that may be something on my system. I'll take a further look.

Also, I changed the project name back (removed the lib prefix), because CMake will automatically add the lib prefix, which would result in a file named liblibsockcanpp*.

@SimonCahill SimonCahill self-assigned this Feb 21, 2024
@SimonCahill SimonCahill added the enhancement New feature or request label Feb 21, 2024
@SimonCahill SimonCahill merged commit 621383e into SimonCahill:master Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants