Skip to content

Conversation

@live627
Copy link
Contributor

@live627 live627 commented Aug 27, 2025

  • wrap code in preformatted html tags
  • do the same in the sceditor
  • bonus: fix php tag processing in the sceditor
  • add buttons for selecting and expanding code blocks with js; don't output them from php
  • remove smfSelectText( ) as it is unused now

- wrap code in preformatted html tags
- do the same in the sceditor
- bonus: fix php tag processing in the sceditor
- do not add php start and end php tags to the final output of the php bbcode
- add buttons for selecting and expanding code blocks with js; don't output them from php
- remove smfSelectText( ) as it is unused now

Signed-off-by: John Rayes <[email protected]>
@ThistleSifter
Copy link

For semantics and accessibility, what about replacing the div header with figure/figcaption?

<figure>
    <figcaption>PHP code: <button>Select</button> <button>Expand></button></figcaption>
    <pre><code>$foo</code></pre>
</figure>

@jdarwood007
Copy link
Member

@live627 This is in draft. Is that intended?

@jdarwood007 jdarwood007 changed the title code tag changes [3.0] code tag changes Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants