Skip to content

make editors full screen when they have focus #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make editors full screen when they have focus #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions base-components/codemirror/footHtml/Codemirror styles.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<link rel="stylesheet" href="js/codemirror/lib/codemirror.css" />
<link rel="stylesheet" href="js/codemirror/theme/base16-dark.css"/>
<link rel="stylesheet" href="js/codemirror/lib/codemirror.css">
<link rel="stylesheet" href="js/codemirror/theme/base16-dark.css">
43 changes: 43 additions & 0 deletions components/1-styling/componentCss/fullscreen-editors.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
body:has(.simplycode-editor-code :focus) {
overflow: hidden;
}
.simplycode-editors:not(.simplycode-dual) .simplycode-editor-code:has(:focus) {
position: fixed;
top: 65px;
bottom: 0;
left: 0;
right: 0;
z-index: 100;
display: flex !important;
flex-direction: column;
}
.simplycode-editors:not(.simplycode-dual) .simplycode-editor-code:has(:focus) .CodeMirror {
flex-grow: 1;
}
.simplycode-editors.simplycode-dual:has(.simplycode-editor-code :focus) {
position: fixed;
top: 65px;
bottom: 0;
left: 0;
right: 0;
z-index: 100;
display: flex !important;
flex-direction: column;
}
.simplycode-editors:not(.simplycode-dual) .simplycode-editor-code.simplycode-dual:has(:focus):has(.CodeMirror ~ .CodeMirror) {
flex-direction: row;
}
.simplycode-editors.simplycode-dual:has(.simplycode-editor-code :focus) .simplycode-previews {
display: none;
}
.simplycode-editors.simplycode-dual:has(.simplycode-editor-code :focus) .simplycode-editor-code {
flex-grow: 1;
height: 100%;
}
.simplycode-editors:not(.simplycode-dual) .simplycode-editor-code.simplycode-dual:has(:focus) .CodeMirror,
.simplycode-editors.simplycode-dual:has(.simplycode-editor-code :focus) .CodeMirror {
height: 100%;
}
.simplycode-html {
grid-column: span 2 / span 2;
}
2 changes: 2 additions & 0 deletions components/1-styling/componentCss/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ nav > ul > li[data-simply-command=expandMenu]::before {
}
.simplycode-part .simplycode-dual {
display: grid;
grid-template-areas: "left right"
"footer footer";
grid-template-columns: 1fr 1fr;
}
.simplycode-part .simplycode-dual-preview {
Expand Down
17 changes: 17 additions & 0 deletions .../component-component-html/commands/tests/addComponentTemplate/testAddComponentTemplate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
function(assert) {
editor = {
"pageData" : {
"component" : {
"parts" : {
"componentTemplates" : []
}
}
}
};

assert.equal(editor.pageData.component.parts.componentTemplates.length, 0);
commands.addComponentTemplate();
assert.equal(editor.pageData.component.parts.componentTemplates.length, 1);
commands.addComponentTemplate();
assert.equal(editor.pageData.component.parts.componentTemplates.length, 2);
}
2 changes: 1 addition & 1 deletion components/component-page-template/componentTemplates/componentPageTemplate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
<div class="simplycode-previews">
<simply-render rel="pagePreview"></simply-render>
</div>
<simply-render rel="componentHtmlValidator"></simply-render>
</div>
<simply-render rel="componentHtmlValidator"></simply-render>
</div>
</template>
</div>
Expand Down
18 changes: 10 additions & 8 deletions components/html-validator/componentTemplates/componentHtmlValidator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<div data-simply-field="code" data-simply-transformer="validateHtml"></div>
<div class="simplycode-html-messages" data-simply-list="validateResult.messages">
<template>
<div class="simplycode-html-message">
<span data-simply-field="message"></span><br>
<span data-simply-field="extract" data-simply-transformer="escapeHtml"></span> on line <span data-simply-field="firstLine"></span> <span data-simply-field="lastLine"></span>
</div>
</template>
<div class="simplycode-html">
<div data-simply-field="code" data-simply-transformer="validateHtml"></div>
<div class="simplycode-html-messages" data-simply-list="validateResult.messages">
<template>
<div class="simplycode-html-message">
<span data-simply-field="message"></span><br>
<span data-simply-field="extract" data-simply-transformer="escapeHtml"></span> on line <span data-simply-field="firstLine"></span> <span data-simply-field="lastLine"></span>
</div>
</template>
</div>
</div>
68 changes: 58 additions & 10 deletions generated.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,50 @@
border: 0;
padding: 5px;
}
/* fullscreen-editors */
body:has(.simplycode-editor-code :focus) {
overflow: hidden;
}
.simplycode-editors:not(.simplycode-dual) .simplycode-editor-code:has(:focus) {
position: fixed;
top: 65px;
bottom: 0;
left: 0;
right: 0;
z-index: 100;
display: flex !important;
flex-direction: column;
}
.simplycode-editors:not(.simplycode-dual) .simplycode-editor-code:has(:focus) .CodeMirror {
flex-grow: 1;
}
.simplycode-editors.simplycode-dual:has(.simplycode-editor-code :focus) {
position: fixed;
top: 65px;
bottom: 0;
left: 0;
right: 0;
z-index: 100;
display: flex !important;
flex-direction: column;
}
.simplycode-editors:not(.simplycode-dual) .simplycode-editor-code.simplycode-dual:has(:focus):has(.CodeMirror ~ .CodeMirror) {
flex-direction: row;
}
.simplycode-editors.simplycode-dual:has(.simplycode-editor-code :focus) .simplycode-previews {
display: none;
}
.simplycode-editors.simplycode-dual:has(.simplycode-editor-code :focus) .simplycode-editor-code {
flex-grow: 1;
height: 100%;
}
.simplycode-editors:not(.simplycode-dual) .simplycode-editor-code.simplycode-dual:has(:focus) .CodeMirror,
.simplycode-editors.simplycode-dual:has(.simplycode-editor-code :focus) .CodeMirror {
height: 100%;
}
.simplycode-html {
grid-column: span 2 / span 2;
}
/* simply-toast */
:root {
--simply-toast-height: 60px;
Expand Down Expand Up @@ -889,6 +933,8 @@
}
.simplycode-part .simplycode-dual {
display: grid;
grid-template-areas: "left right"
"footer footer";
grid-template-columns: 1fr 1fr;
}
.simplycode-part .simplycode-dual-preview {
Expand Down Expand Up @@ -4315,8 +4361,8 @@
<div class="simplycode-previews">
<simply-render rel="pagePreview"></simply-render>
</div>
<simply-render rel="componentHtmlValidator"></simply-render>
</div>
<simply-render rel="componentHtmlValidator"></simply-render>
</div>
</template>
</div>
Expand Down Expand Up @@ -4681,14 +4727,16 @@
<simply-render rel="simply-toolbar"></simply-render>
</template>
<template id="componentHtmlValidator">
<div class="simplycode-html">
<div data-simply-field="code" data-simply-transformer="validateHtml"></div>
<div class="simplycode-html-messages" data-simply-list="validateResult.messages">
<template>
<div class="simplycode-html-message">
<span data-simply-field="message"></span><br>
<span data-simply-field="extract" data-simply-transformer="escapeHtml"></span> on line <span data-simply-field="firstLine"></span> <span data-simply-field="lastLine"></span>
</div>
</template>
<div class="simplycode-html-messages" data-simply-list="validateResult.messages">
<template>
<div class="simplycode-html-message">
<span data-simply-field="message"></span><br>
<span data-simply-field="extract" data-simply-transformer="escapeHtml"></span> on line <span data-simply-field="firstLine"></span> <span data-simply-field="lastLine"></span>
</div>
</template>
</div>
</div>
</template>
<template id="menu">
Expand Down Expand Up @@ -5801,8 +5849,8 @@ <h1>App preview</h1>
<script src="js/codemirror/mode/javascript/javascript.js"></script>
<script src="js/codemirror/mode/xml/xml.js"></script>
<!-- Codemirror styles -->
<link rel="stylesheet" href="js/codemirror/lib/codemirror.css" />
<link rel="stylesheet" href="js/codemirror/theme/base16-dark.css"/>
<link rel="stylesheet" href="js/codemirror/lib/codemirror.css">
<link rel="stylesheet" href="js/codemirror/theme/base16-dark.css">
<!-- Data change codeMirror -->
<script>
document.addEventListener("simply-data-changed", function(event) {
Expand Down