Skip to content

is online/offline not working with variables #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AyhamAl-Ali opened this issue Jun 27, 2021 · 10 comments
Closed

is online/offline not working with variables #4125

AyhamAl-Ali opened this issue Jun 27, 2021 · 10 comments
Labels
addon-related An issue that is related to an addon and not Skript.

Comments

@AyhamAl-Ali
Copy link
Member

Description

using is online/offline condition with variables is not working.

Steps to Reproduce

set {_p} to player
send "1" if {_p} is online # should send 1 but doesn't send anything
send "0" if {_p} is offline # should send 0 but doesn't send anything

Expected Behavior

Should send 1 if online and 0 if offline

Errors / Screenshots

None

Server Information

  • Server version/platform: 1.16.5 Paper-771
  • Skript version: 2.5.3

Additional Context

image

image

@TPGamesNL
Copy link
Member

Likely addon conflict, probably DiSky, try without it

@TPGamesNL TPGamesNL added the waiting for reply The report needs a response from the reporter to determine course of action. label Jun 28, 2021
@AyhamAl-Ali
Copy link
Member Author

Likely addon conflict, probably DiSky, try without it

Not using that.
My current addons

image

@TPGamesNL
Copy link
Member

One of them has a type named 'onlinestatus', check which

@AyhamAl-Ali
Copy link
Member Author

okay I will let you know as soon as I can.

@OGContent
Copy link

Description

using is online/offline condition with variables is not working.

Steps to Reproduce

set {_p} to player
send "1" if {_p} is online # should send 1 but doesn't send anything
send "0" if {_p} is offline # should send 0 but doesn't send anything

Expected Behavior

Should send 1 if online and 0 if offline

Errors / Screenshots

None

Server Information

  • Server version/platform: 1.16.5 Paper-771
  • Skript version: 2.5.3

Additional Context

image

image

image
the else didn't work somehow
git-Paper-"e04368045" mc: 1.16.5
skript version 2.5.3

@AyhamAl-Ali
Copy link
Member Author

Can confirm that it works as expected without addons only TuSKe. (haven't yet found which addon conflict with this)

the else didn't work somehow

Can confirm as well. there was a fix for EffDoIf for stopping the whole trigger instead of the line itself in 2.6.0 not sure if this is related.

@AyhamAl-Ali
Copy link
Member Author

It's Vixio, see https://github.com/iBlitzkriegi/Vixio/blob/9cca56fa1fa4cb6253000b1175e300e4bf2efe21/src/main/java/me/iblitzkriegi/vixio/registration/Types.java#L224-L241

I suspected that from the beginning. Is there a way to maybe add a setting in each script to make Skript's vanilla effects, expressions, types etc. have a higher priority than addons? or should I make another suggestion for that?

@TPGamesNL
Copy link
Member

They are parsed first, but CondCompare comes before CondIsOnline, so that wouldn't matter here. It would be possible to make CondCompare be attempted last, which would also solve #4123 (comment)

@AyhamAl-Ali
Copy link
Member Author

They are parsed first, but CondCompare comes before CondIsOnline, so that wouldn't matter here. It would be possible to make CondCompare be attempted last, which would also solve #4123 (comment)

Indeed that would be good I think.

@AyhamAl-Ali AyhamAl-Ali added addon-related An issue that is related to an addon and not Skript. and removed waiting for reply The report needs a response from the reporter to determine course of action. labels Nov 4, 2022
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon-related An issue that is related to an addon and not Skript.
Projects
None yet
Development

No branches or pull requests

3 participants