Online status. #4826
Closed
Online status. #4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your efforts again :) The issue from other addons should be fixed from their side however, the issue is because other addons (Vixio & old Disky) had a type called Adding to that I don't think this change will fix anything as it's not the expression's code issue. A side note, it's preferred to suggest changes on discord with Skript team (publicly or privately) and maybe community before working on them in case they do not meet the contribution guidelines or outside Skript's scope to not make efforts on something that will probably not be accepted :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So, i found some people that couldn't get their online status too work.
So i made a fix, this should work, with the "broken" addons.
Target Minecraft Versions: any
Requirements: none
Related Issues: #4825