-
-
Notifications
You must be signed in to change notification settings - Fork 390
Minecraft Structures #5222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/feature
Are you sure you want to change the base?
Minecraft Structures #5222
Conversation
Just a note: this is not related to WorldGuard. |
src/main/java/ch/njol/skript/effects/EffStructureSaveUnregister.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondStructureExists.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffStructureSaveUnregister.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffStructureSaveUnregister.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/sections/EffSecStructurePlace.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprStructureSectionInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprStructureInfo.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use some tests too
src/main/java/ch/njol/skript/expressions/ExprStructureSectionInfo.java
Outdated
Show resolved
Hide resolved
…ript into feature/structures
src/main/java/ch/njol/skript/expressions/ExprStructureSectionInfo.java
Outdated
Show resolved
Hide resolved
…nfo.java Co-authored-by: Patrick Miller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed palette is spelled "pallet" everywhere, that should be fixed.
src/main/java/ch/njol/skript/expressions/ExprStructureInfo.java
Outdated
Show resolved
Hide resolved
closing due to inactivity |
5 months is a crazy inactive closure period |
6 months since your activity tho just like majority of the other ones that got closed |
yes i measure from the first requested change that hasn't been addressed or responded to (march 11th) |
Only has 1 approved review. The rest are pending. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few other things I noticed:
- License headers can be removed now
- The
palette
property is referred to aspallet
in most places. This should be corrected.
Description
Notes:
Exactly how WorldGuard works for creating a new region. This makes ease of use way better.
Target Minecraft Versions: 1.17.1+
Requirements: Spigot 1.17.1+
Related Issues: none