Skip to content

Minecraft Structures #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: dev/feature
Choose a base branch
from
Open

Minecraft Structures #5222

wants to merge 44 commits into from

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Nov 25, 2022

Description

place structure "minecraft:end_city" at player's location:
    set includes entities to false
    set integrity to 0.9
    set pallet to 2
    set rotation to clockwise 90
    set mirror to left to right

Notes:

  • Rather than creating an empty structure object and filling it, I made it so the syntax supports creation of a structure directly without having to have another syntax just to fill the structure like Spigot API handles.
    Exactly how WorldGuard works for creating a new region. This makes ease of use way better.

Target Minecraft Versions: 1.17.1+
Requirements: Spigot 1.17.1+
Related Issues: none

@TheLimeGlass TheLimeGlass added the feature Pull request adding a new feature. label Nov 25, 2022
@TheLimeGlass TheLimeGlass changed the title Feature/structures Structures (WorldGuard replacement) Nov 25, 2022
@Moderocky Moderocky changed the title Structures (WorldGuard replacement) Minecraft Structures Dec 22, 2022
@Moderocky
Copy link
Member

Just a note: this is not related to WorldGuard.
WorldGuard is a plugin that allows players to select areas of the map and apply rules to them (e.g. players can't break blocks, no creeper explosions, no entry)
whereas Minecraft Structures are like saved schematics of buildings, etc. that can be pasted into the map.

Copy link
Contributor

@kiip1 kiip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use some tests too

@TheLimeGlass TheLimeGlass requested review from kiip1 and Moderocky and removed request for kiip1 February 16, 2023 03:27
@sovdeeth sovdeeth removed the 2.8 label Dec 30, 2023
@TheLimeGlass TheLimeGlass requested a review from kiip1 March 10, 2024 02:37
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed palette is spelled "pallet" everywhere, that should be fixed.

@Fusezion Fusezion mentioned this pull request Sep 12, 2024
@sovdeeth
Copy link
Member

closing due to inactivity

@sovdeeth sovdeeth closed this Sep 15, 2024
@TheLimeGlass TheLimeGlass reopened this Sep 18, 2024
@TheLimeGlass
Copy link
Contributor Author

5 months is a crazy inactive closure period

@Fusezion
Copy link
Contributor

Fusezion commented Sep 18, 2024

5 months is a crazy inactive closure period

6 months since your activity tho just like majority of the other ones that got closed

@sovdeeth
Copy link
Member

yes i measure from the first requested change that hasn't been addressed or responded to (march 11th)

@TheLimeGlass TheLimeGlass requested review from UnderscoreTud and removed request for kiip1 September 18, 2024 02:56
@TheLimeGlass
Copy link
Contributor Author

Only has 1 approved review. The rest are pending.

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few other things I noticed:

  • License headers can be removed now
  • The palette property is referred to as pallet in most places. This should be corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants