-
-
Notifications
You must be signed in to change notification settings - Fork 391
🚀 Add Structure Support to Docs #5523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheLimeGlass
merged 4 commits into
SkriptLang:master
from
AyhamAl-Ali:feature/add-structures-to-docs
Mar 18, 2023
Merged
🚀 Add Structure Support to Docs #5523
TheLimeGlass
merged 4 commits into
SkriptLang:master
from
AyhamAl-Ali:feature/add-structures-to-docs
Mar 18, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Event priority syntax from docs
Moderocky
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work Ayham! 🚀
Moderocky
reviewed
Mar 15, 2023
APickledWalrus
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would just make the minor change I suggested about event priority field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Related to Skript's official documentation.
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yet with another docs improvement PR :D
In this PR, I've:
[with priority (lowest|low|normal|high|highest|monitor)]
from each event element in docs --I will open a PR in skript-docs to add that as a note at the beginning of Events page(Done)Preview: https://ayhamal-ali.github.io/Skript/
Target Minecraft Versions: Any
Requirements: None
Related Issues: None
Related PRs: