Skip to content

🚀 Add Structure Support to Docs #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AyhamAl-Ali
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali commented Mar 15, 2023

Description

Yet with another docs improvement PR :D

In this PR, I've:

  • Added Structure support with their required and optional EntryData list
  • Removed Priority syntax [with priority (lowest|low|normal|high|highest|monitor)] from each event element in docs -- I will open a PR in skript-docs to add that as a note at the beginning of Events page (Done)

Preview: https://ayhamal-ali.github.io/Skript/


Target Minecraft Versions: Any
Requirements: None
Related Issues: None
Related PRs:

- Remove Event priority syntax from docs
@AyhamAl-Ali AyhamAl-Ali added enhancement Feature request, an issue about something that could be improved, or a PR improving something. documentation Related to Skript's official documentation. labels Mar 15, 2023
@AyhamAl-Ali AyhamAl-Ali changed the title 🚀 Add Strutcture Support 🚀 Add Strutcture Support to Docs Mar 15, 2023
@AyhamAl-Ali AyhamAl-Ali marked this pull request as draft March 15, 2023 10:33
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Ayham! 🚀

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just make the minor change I suggested about event priority field.

@TPGamesNL TPGamesNL changed the title 🚀 Add Strutcture Support to Docs 🚀 Add Structure Support to Docs Mar 15, 2023
@AyhamAl-Ali AyhamAl-Ali marked this pull request as ready for review March 17, 2023 16:53
@TheLimeGlass TheLimeGlass merged commit f8f0437 into SkriptLang:master Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants