Make visual effects serializable #7114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
requested changes
Sep 26, 2024
Member
|
also you can remove the license from the top of the files |
Co-authored-by: Efy <35348263+Efnilite@users.noreply.github.com>
Romitou
force-pushed
the
feature/yggdrasil-visual-effect
branch
from
d95d3cb to
b2c231e
Compare
Efnilite
added
the
enhancement
sovdeeth
requested changes
Sep 26, 2024
Member
sovdeeth
left a comment
sovdeeth
left a comment
There was a problem hiding this comment.
Does this handle types with data, like vibrations or dust particles? Also, I'd like to see some regression tests if possible.
ShaneBeee
reviewed
Sep 29, 2024
| @Override | ||
| public Fields serialize(VisualEffectType visualEffectType) { | ||
| Fields fields = new Fields(); | ||
| fields.putObject("id", visualEffectType.getId()); |
Contributor
There was a problem hiding this comment.
doing a quick look thru the VisualEffectType code, I see this regarding IDs
public String getId() {
return effect.getDeclaringClass().getSimpleName() + "." + effect.name();
}The issue here is the ID is the class name and enum name.
Problem comes from the fact Mojang has changed particle names several times in the last few versions.
And as of I believe 1.21 Bukkit has changed a whole bunch of the enums.
That said, this is not version safe.
Member
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started by @TPGamesNL in PR #4123 (the commit has been cherry-picked and the author has been kept for credits), providing a serializer for
VisualEffectTypeallows to serializeVisualEffectcorrectly. In fact, this should have been handled bysimpleClassLoaders, where this specific class was originally registered.However, the
Yggdrasil#getSerializermethod did not return a serializer: aSimpleClassResolverextends fromClassResolverand not from aYggdrasilSerializerlike the others. A fix is therefore to directly register this serializer at the root ofclassResolvers.https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/yggdrasil/Yggdrasil.java
Target Minecraft Versions: any
Requirements: none
Related Issues: #4196