-
-
Notifications
You must be signed in to change notification settings - Fork 391
Improve generated json by JSONGenerator #7633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd prefer to add the null values so that all attributes are present. What do you think? |
…o patch/update-json-generator
that makes more sense actually, should be good now |
Solves #7625 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. as a final thought, do you think we should add a formatVersion
top level key that can be incremented when there are format changes? we can do a basic semver like 1.1
there also appear to be conflicts |
…o patch/update-json-generator
…o patch/update-json-generator
…o patch/update-json-generator
Why are a bunch of test classes that shouldn't be loaded outside of tests now getting an additional check for testmode? |
should be good now! |
Co-authored-by: sovdee <[email protected]>
Description
/sk gen-docs
or theskriptGenerateDocumentation
task can now be run without the templates. This results in only generating the json documentation.This is prep work for the new docs at https://skript.efnilite.dev
Target Minecraft Versions: any
Requirements: none
Related Issues: #7625, SkriptLang/skript-docs#10, SkriptLang/skript-docs#37