Repository navigation
Add support for GITHUB_TOKEN environment variable - #216
Merged
Merged
Conversation
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
|
jerry-skydio
reviewed
Sep 4, 2025
jerry-skydio
reviewed
Sep 4, 2025
jerry-skydio
reviewed
Sep 4, 2025
jerry-skydio
left a comment
Collaborator
There was a problem hiding this comment.
can we settle on supporting only GITHUB_TOKEN? I'd rather not have details from another project enter this codebase, and GITHUB_TOKEN seems more generic
Add support for GITHUB_TOKEN environment variable in authentication chain, providing compatibility with GitHub CLI and other GitHub tools. Environment variable is checked after config file but before git credential helper fallback. Priority order: 1. Command line argument (--github-oauth) 2. Config file (~/.revupconfig) 3. Environment variable (GITHUB_TOKEN) [NEW] 4. Git credential helper 5. Error if none found Features: - Maintains all existing functionality and fallbacks - Proper token redaction in logs for security - Clear debug messaging showing which method was used - Updated error message to mention environment variable option This change improves user experience by allowing the same environment variable used by gh and other GitHub tools, reducing setup friction. Branch: main Topic: env-token-support
arturo-skydio
force-pushed
the
arturo/revup/main/env-token-support
branch
from
September 4, 2025 18:31
2d97d1a to
4d86e7d
Compare
Contributor
Author
Yup, I'll just change it to accept GITHUB_TOKEN |
arturo-skydio
force-pushed
the
arturo/revup/main/env-token-support
branch
from
September 25, 2025 21:09
4d86e7d to
50d601a
Compare
| raise RevupUsageException( | ||
| "No Github OAuth token found! " | ||
| "Login with 'gh auth login' " | ||
| "Set th GITHUB_TOKEN environment variable, " |
arturo-skydio
force-pushed
the
arturo/revup/main/env-token-support
branch
from
September 30, 2025 23:48
50d601a to
386fd72
Compare
| @@ -0,0 +1,9 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
don't add this file in this PR. make a dedicated pr if you need this
Contributor
Author
There was a problem hiding this comment.
oh yea, didn't actually mean to commit this file, removed now
arturo-skydio
force-pushed
the
arturo/revup/main/env-token-support
branch
from
October 1, 2025 02:38
386fd72 to
b6ec92f
Compare
jerry-skydio
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for GITHUB_TOKEN environment variable in authentication
chain, providing compatibility with GitHub CLI and other GitHub tools.
Environment variable is checked after config file but before git
credential helper fallback.
Priority order:
Features:
This change improves user experience by allowing the same environment
variable used by gh and other GitHub tools, reducing setup friction.
Branch: main
Topic: env-token-support