Skip to content

Fix missing event loop cleanup - #235

Merged
jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/evcleanup
Apr 24, 2026
Merged

jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/evcleanup

Conversation

@jerry-skydio

Copy link
Copy Markdown
Collaborator

Prevents a stacktrace if we hit an exception

Exception ignored in: <function BaseEventLoop.del at 0x7ff9244263a0>
Traceback (most recent call last):
File "/usr/lib/python3.8/asyncio/base_events.py", line 656, in del
self.close()
File "/usr/lib/python3.8/asyncio/unix_events.py", line 58, in close
super().close()
File "/usr/lib/python3.8/asyncio/selector_events.py", line 92, in close
self._close_self_pipe()
File "/usr/lib/python3.8/asyncio/selector_events.py", line 99, in _close_self_pipe
self._remove_reader(self._ssock.fileno())
File "/usr/lib/python3.8/asyncio/selector_events.py", line 276, in _remove_reader
key = self._selector.get_key(fd)
File "/usr/lib/python3.8/selectors.py", line 190, in get_key
return mapping[fileobj]
File "/usr/lib/python3.8/selectors.py", line 71, in getitem
fd = self._selector._fileobj_lookup(fileobj)
File "/usr/lib/python3.8/selectors.py", line 225, in _fileobj_lookup
return _fileobj_to_fd(fileobj)
File "/usr/lib/python3.8/selectors.py", line 42, in _fileobj_to_fd
raise ValueError("Invalid file descriptor: {}".format(fd))
ValueError: Invalid file descriptor: -1

Prevents a stacktrace if we hit an exception

Exception ignored in: <function BaseEventLoop.__del__ at 0x7ff9244263a0>
Traceback (most recent call last):
  File "/usr/lib/python3.8/asyncio/base_events.py", line 656, in __del__
    self.close()
  File "/usr/lib/python3.8/asyncio/unix_events.py", line 58, in close
    super().close()
  File "/usr/lib/python3.8/asyncio/selector_events.py", line 92, in close
    self._close_self_pipe()
  File "/usr/lib/python3.8/asyncio/selector_events.py", line 99, in _close_self_pipe
    self._remove_reader(self._ssock.fileno())
  File "/usr/lib/python3.8/asyncio/selector_events.py", line 276, in _remove_reader
    key = self._selector.get_key(fd)
  File "/usr/lib/python3.8/selectors.py", line 190, in get_key
    return mapping[fileobj]
  File "/usr/lib/python3.8/selectors.py", line 71, in __getitem__
    fd = self._selector._fileobj_lookup(fileobj)
  File "/usr/lib/python3.8/selectors.py", line 225, in _fileobj_lookup
    return _fileobj_to_fd(fileobj)
  File "/usr/lib/python3.8/selectors.py", line 42, in _fileobj_to_fd
    raise ValueError("Invalid file descriptor: {}".format(fd))
ValueError: Invalid file descriptor: -1
@jerry-skydio

Copy link
Copy Markdown
Collaborator Author

Reviews in this chain:
└#235 Fix missing event loop cleanup

@jerry-skydio

Copy link
Copy Markdown
Collaborator Author
# head base diff date summary
0 96549cb4 e7e87173 diff Apr 23 16:31 PM 1 file changed, 4 insertions(+), 1 deletion(-)

@jerry-skydio
jerry-skydio merged commit 8250bdb into main Apr 24, 2026
5 checks passed
@jerry-skydio
jerry-skydio deleted the jerry/revup/main/evcleanup branch April 24, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants