Repository navigation
upload: Support Github teams as reviewers - #240
Merged
Merged
Conversation
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
|
aaron-skydio
force-pushed
the
aaron/revup/main/teams
branch
from
April 28, 2026 23:06
031f869 to
b5279c6
Compare
Collaborator
|
will conflict with #236 -- mind reviewing that first? |
Reviewers tagged as org/team-slug are resolved via the Github teams API and passed as teamIds to requestReviews. Github does not support teams as assignees; since Github usernames cannot contain "/", any org/slug entry in Assignees is unambiguously invalid and raises a usage error. auto_add_users=r2a/both likewise does not copy teams from Reviewers into Assignees. To avoid repeatedly triggering Github's code review auto-assignment, team membership is fetched alongside the team id and the team is not re-requested when one of its members is already a reviewer on the PR. Teams with more than 100 members fall back to always re-requesting. We emit a warning when either of these happens. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Topic: teams Reviewers: jerry,brian-k
aaron-skydio
force-pushed
the
aaron/revup/main/teams
branch
from
April 28, 2026 23:10
b5279c6 to
f3ae84f
Compare
Contributor
Author
|
oh boy. yeah will get to that, and feel free to not review this until i do |
Contributor
Author
|
looking at the description there, very nice and yeah i'll just put this on top of that one |
jerry-skydio
approved these changes
May 19, 2026
Collaborator
|
oh hey it doesn't conflict after all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers tagged as org/team-slug are resolved via the Github teams API
and passed as teamIds to requestReviews. Github does not support teams
as assignees; since Github usernames cannot contain "/", any org/slug
entry in Assignees is unambiguously invalid and raises a usage error.
auto_add_users=r2a/both likewise does not copy teams from Reviewers
into Assignees.
To avoid repeatedly triggering Github's code review auto-assignment,
team membership is fetched alongside the team id and the team is not
re-requested when one of its members is already a reviewer on the PR.
Teams with more than 100 members fall back to always re-requesting. We
emit a warning when either of these happens.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com
Topic: teams
Reviewers: jerry,brian-k