Skip to content

logs: Add --log-to-file to write debug logs to a file - #300

Merged
jerry-skydio merged 1 commit into
mainfrom
brian.kubisiak/revup/main/verbose-logs
Sep 23, 2026
Merged

jerry-skydio merged 1 commit into
mainfrom
brian.kubisiak/revup/main/verbose-logs

Conversation

@brian-kubisiak-skydio

@brian-kubisiak-skydio brian-kubisiak-skydio commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Verbose output is usually wanted after a command has already run and
exited, which -v can't provide retroactively. Leaving -v on all the
time isn't a workable substitute either, since it clutters normal
output.

Add a second logging backend, off by default and enabled with
--log-to-file. It writes debug logs to $XDG_STATE_HOME/revup/logs, one
file per invocation named after the start time and pid, keeping 20
runs of history. The root logger level now only gates what any handler
can see; each handler decides for itself, so the console keeps showing
INFO while the file gets DEBUG. Both handlers share one filter, so an
oauth discovered partway through a run is redacted in the file too.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Signed-off-by: Brian Kubisiak brian.kubisiak@skydio.com

@brian-kubisiak-skydio

brian-kubisiak-skydio commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Reviews in this chain:
└#300 logs: Add --log-to-file to write debug logs to a file

@brian-kubisiak-skydio

brian-kubisiak-skydio commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor Author
# head base diff date summary
0 6ffa1e71 20c37803 diff Sep 15 15:04 PM 5 files changed, 340 insertions(+), 30 deletions(-)
1 54f5427b 20c37803 diff Sep 15 15:36 PM 1 file changed, 1 insertion(+), 3 deletions(-)
2 c2bd5b4f 20c37803 diff Sep 16 13:38 PM 2 files changed, 20 insertions(+), 6 deletions(-)

@aaron-skydio aaron-skydio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, yeah this is useful

Comment thread docs/revup.md Outdated
Comment thread docs/revup.md Outdated
@brian-kubisiak-skydio brian-kubisiak-skydio changed the title logs: Add --verbose-logs to write debug logs to a file logs: Add --log-to-file to write debug logs to a file Sep 16, 2026
@brian-kubisiak-skydio
brian-kubisiak-skydio force-pushed the brian.kubisiak/revup/main/verbose-logs branch from 54f5427 to c2bd5b4 Compare September 16, 2026 13:38
Verbose output is usually wanted after a command has already run and
exited, which -v can't provide retroactively. Leaving -v on all the
time isn't a workable substitute either, since it clutters normal
output.

Add a second logging backend, off by default and enabled with
--log-to-file. It writes debug logs to $XDG_STATE_HOME/revup/logs, one
file per invocation named after the start time and pid, keeping 20
runs of history. The root logger level now only gates what any handler
can see; each handler decides for itself, so the console keeps showing
INFO while the file gets DEBUG. Both handlers share one filter, so an
oauth discovered partway through a run is redacted in the file too.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Brian Kubisiak <brian.kubisiak@skydio.com>
@jerry-skydio
jerry-skydio force-pushed the brian.kubisiak/revup/main/verbose-logs branch from c2bd5b4 to 889429a Compare September 23, 2026 02:02
@jerry-skydio
jerry-skydio merged commit cda06a4 into main Sep 23, 2026
6 checks passed
@jerry-skydio
jerry-skydio deleted the brian.kubisiak/revup/main/verbose-logs branch September 23, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants