Repository navigation
main: Fix ctrl-c being ignored at the upload confirmation prompt - #303
Merged
Merged
Conversation
Installing a loop signal handler for sigint replaces python's default handler, so KeyboardInterrupt is never raised. Synchronous code running inside main, such as the input() in wait_for_confirmation, blocks until enter is pressed, after which the queued cancel fires at the next await and interrupts the upload partway through pushing. Keep the default handler instead, and cancel main once the KeyboardInterrupt reaches the top level so it still unwinds and cleans up rather than being abandoned suspended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Brian Kubisiak <brian.kubisiak@skydio.com>
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
jerry-skydio
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing a loop signal handler for sigint replaces python's default
handler, so KeyboardInterrupt is never raised. Synchronous code
running inside main, such as the input() in wait_for_confirmation,
blocks until enter is pressed, after which the queued cancel fires at
the next await and interrupts the upload partway through pushing.
Keep the default handler instead, and cancel main once the
KeyboardInterrupt reaches the top level so it still unwinds and cleans
up rather than being abandoned suspended.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Signed-off-by: Brian Kubisiak brian.kubisiak@skydio.com