Repository navigation
upload: Keep a review stacked on its relative branch's tip - #304
Merged
Merged
Conversation
A relative branch is someone else's work that a review is stacked on, so the review has to sit exactly on the commit it will be uploaded to, the same rule a relative series already follows. Rebase detection instead asked whether the remote base is an ancestor of the local one, which is right for a base branch (don't re-push every time master moves) but always true for a relative branch that has moved forward. Upload retargeted the pr on the forge and then skipped the push as a rebase, leaving the review based on an old tip and showing the relative branch's commits as its own. A relative branch review is now either nochange, when it is already on the tip, or pushed. This means such a review re-pushes whenever the relative branch moves, even without --rebase.
Collaborator
Author
|
Reviews in this chain: |
Collaborator
Author
brian-kubisiak-skydio
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A relative branch is someone else's work that a review is stacked on, so the
review has to sit exactly on the commit it will be uploaded to, the same rule a
relative series already follows. Rebase detection instead asked whether the
remote base is an ancestor of the local one, which is right for a base branch
(don't re-push every time master moves) but always true for a relative branch
that has moved forward. Upload retargeted the pr on the forge and then skipped
the push as a rebase, leaving the review based on an old tip and showing the
relative branch's commits as its own.
A relative branch review is now either nochange, when it is already on the tip,
or pushed. This means such a review re-pushes whenever the relative branch
moves, even without --rebase.