upload: Allow clearing draft status with draft_on_create_only - #305
Merged
Merged
Conversation
Two fixes for draft_on_create_only: - `revup status` printed "(draft)" for a pr the user had already marked ready, since the flag was only handled in populate_update_info which doesn't run for status. It's now handled in query() instead. - A pr revup drafted for being deep in a stack stayed a draft forever, even after it left that depth. Revup may now mark a draft pr ready, it just never turns a ready pr back into a draft. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Author
|
Reviews in this chain: |
Collaborator
Author
aaron-skydio
approved these changes
Sep 28, 2026
brian-kubisiak-skydio
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for draft_on_create_only:
revup statusprinted "(draft)" for a pr the user had already markedready, since the flag was only handled in populate_update_info which
doesn't run for status. It's now handled in query() instead.
even after it left that depth. Revup may now mark a draft pr ready,
it just never turns a ready pr back into a draft.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com