python: Use builtin generics and X | Y unions in annotations - #309
Merged
Merged
Conversation
Collaborator
Author
|
Reviews in this chain: |
Collaborator
Author
jerry-skydio
force-pushed
the
jerry/revup/main/Uploadrelatives
branch
from
October 1, 2026 23:11
a7c727b to
a8247f6
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/types
branch
2 times, most recently
from
October 1, 2026 23:11
53fe62c to
4f36ed7
Compare
jerry-skydio
force-pushed
the
jerry/revup/main/Uploadrelatives
branch
from
October 1, 2026 23:11
a8247f6 to
7241057
Compare
aaron-skydio
approved these changes
Oct 2, 2026
Every module now has `from __future__ import annotations`, so annotations can use list/dict/set/tuple/type and `X | None` instead of the typing equivalents. Only code that evaluates types at runtime (shell._HANDLE, a cast in git.py) still imports from typing. Ruff enforces this going forward: UP006/UP007/UP045/UP037 reject the old spellings and quoted annotations, and FA102 catches the new ones in a file that's missing the future import, which would break on python 3.8.
jerry-skydio
force-pushed
the
jerry/revup/main/types
branch
from
October 3, 2026 00:00
4f36ed7 to
ed23370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every module now has
from __future__ import annotations, so annotations can uselist/dict/set/tuple/type and
X | Noneinstead of the typing equivalents. Onlycode that evaluates types at runtime (shell._HANDLE, a cast in git.py) still
imports from typing.
Ruff enforces this going forward: UP006/UP007/UP045/UP037 reject the old spellings
and quoted annotations, and FA102 catches the new ones in a file that's missing
the future import, which would break on python 3.8.