Skip to content

upload: Log the output of the pre-upload command #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerry-skydio merged 1 commit into from
Oct 3, 2026
Merged

upload: Log the output of the pre-upload command #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions revup/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import argparse
import enum
import logging
import os
import shlex
import subprocess
Expand Down Expand Up @@ -31,6 +32,7 @@ def run_pre_upload(pre_upload: str, ref_args: List[str], repo_root: str) -> None
if os.path.isfile(in_repo_root):
command[0] = in_repo_root

logging.debug("Running pre-upload command: {}".format(" ".join(command)))
try:
result = subprocess.run(
command,
Expand All @@ -42,6 +44,8 @@ def run_pre_upload(pre_upload: str, ref_args: List[str], repo_root: str) -> None
)
except OSError as exc:
raise RevupShellException(f"Couldn't run pre-upload command: {exc}") from exc
if result.stdout:
logging.debug("Pre-upload output:\n{}".format(result.stdout.rstrip()))
if result.returncode != 0:
raise RevupShellException(
f"Pre-upload command failed:\n{result.stdout}\n"
Expand Down
Loading