Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task v2 proxy location update #1671

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 28, 2025

Important

Update TaskV2Block.execute to use workflow_run.proxy_location for proxy location handling.

  • Behavior:
    • In TaskV2Block.execute, update proxy_location to use workflow_run.proxy_location instead of ProxyLocation.NONE.
    • Adds a check for workflow_run existence and raises ValueError if not found.

This description was created by Ellipsis for cd2c6b5. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cd2c6b5 in 41 seconds

More details
  • Looked at 30 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:52
  • Draft comment:
    ProxyLocation is used but not imported. Re-import it to avoid a NameError.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_zutT9Gdwu1qDLGLW


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit c7f56f3 into main Jan 28, 2025
7 checks passed
@wintonzheng wintonzheng deleted the shu/remove_hardcode_proxylocation_none branch January 28, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant