Merged
Conversation
Replaced indexOf-based loops with index iteration to improve performance and avoid potential issues with duplicate elements. Optimized value parsing in getJsonPrimitive by using try-catch blocks. These changes enhance code clarity, efficiency, and robustness.
Moved the JSON apply changes logic in MainActivity to a background thread for better UI responsiveness and added a loading indicator. Updated app version to 1.8.4 and added a new string resource for the loading message.
Introduced the isApplyingChanges boolean to track when changes are being applied, preventing the toolbar from showing during this process. This helps avoid UI inconsistencies while background operations are in progress.
Refactored RawJsonView to use precompiled regex patterns for more efficient and accurate JSON syntax highlighting. Updated AndroidRawJsonView to ensure UI updates and loading state changes are posted to the main thread, improving thread safety and UI responsiveness.
Introduces a public isLoading flag in MainActivity to better track and control loading state. Updates logic to use this flag for progress view visibility and loading completion, ensuring UI elements like the toolbar are hidden appropriately during loading operations.
Refactored MainActivity to centralize unsaved changes dialog logic and made unsavedChanges public. Updated AndroidFileManager and MainActivity to prompt users to save or discard unsaved changes before importing files or performing actions that may overwrite data. Added a new string resource for 'saving file in progress' message.
Updated the app versionName to 1.8.4.1 and versionCode to 57 in build.gradle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.