ITK_DIR avoid override #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thewtex
commented
Dec 19, 2020
thewtex
commented
- BUG: Do not override ITK_DIR in CMake package configurations
- COMP: Update JsonCpp API calls
Enable a different ITK to build built against when building the CLI, e.g. when cross-compiling.
To address:
[3/5] Building CXX object CMakeFiles/CLPExample1Lib.dir/CLPExample1.cxx.o
In file included from /home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:1:
/home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx: In function ‘int ModuleEntryPoint(int, char**)’:
./CLPExample1CLP.h:36:20: warning: ‘Reader’ is deprecated: Use CharReader and CharReaderBuilder instead. [-Wdeprecated-declarations]
36 | Json::Reader reader; \
| ^~~~~~
./CLPExample1CLP.h:715:62: note: in expansion of macro ‘GENERATE_DESERIALIZATION’
715 | #define PARSE_ARGS GENERATE_LOGO;GENERATE_XML;GENERATE_TCLAP;GENERATE_DESERIALIZATION;GENERATE_ECHOARGS;GENERATE_ProcessInformationAddressDecoding;GENERATE_SERIALIZATION;
| ^~~~~~~~~~~~~~~~~~~~~~~~
/home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:5:3: note: in expansion of macro ‘PARSE_ARGS’
5 | PARSE_ARGS;
| ^~~~~~~~~~
In file included from /home/matt/src/jsoncpp/include/json/json.h:11,
from /home/matt/src/SlicerExecutionModel/ModuleDescriptionParser/JsonSerializationUtilities.h:18,
from ./CLPExample1CLP.h:15,
from /home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:1:
/home/matt/src/jsoncpp/include/json/reader.h:37:63: note: declared here
37 | "Use CharReader and CharReaderBuilder instead.") JSON_API Reader {
| ^~~~~~
In file included from /home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:1:
./CLPExample1CLP.h:36:20: warning: ‘Json::Reader::Reader()’ is deprecated: Use CharReader and CharReaderBuilder instead [-Wdeprecated-declarations]
36 | Json::Reader reader; \
| ^~~~~~
./CLPExample1CLP.h:715:62: note: in expansion of macro ‘GENERATE_DESERIALIZATION’
715 | #define PARSE_ARGS GENERATE_LOGO;GENERATE_XML;GENERATE_TCLAP;GENERATE_DESERIALIZATION;GENERATE_ECHOARGS;GENERATE_ProcessInformationAddressDecoding;GENERATE_SERIALIZATION;
| ^~~~~~~~~~~~~~~~~~~~~~~~
/home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:5:3: note: in expansion of macro ‘PARSE_ARGS’
5 | PARSE_ARGS;
| ^~~~~~~~~~
In file included from /home/matt/src/jsoncpp/include/json/json.h:11,
from /home/matt/src/SlicerExecutionModel/ModuleDescriptionParser/JsonSerializationUtilities.h:18,
from ./CLPExample1CLP.h:15,
from /home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:1:
/home/matt/src/jsoncpp/include/json/reader.h:56:3: note: declared here
56 | Reader();
| ^~~~~~
In file included from /home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:1:
./CLPExample1CLP.h:89:32: warning: ‘StyledStreamWriter’ is deprecated: Use StreamWriterBuilder instead [-Wdeprecated-declarations]
89 | Json::StyledStreamWriter writer; \
| ^~~~~~
./CLPExample1CLP.h:715:148: note: in expansion of macro ‘GENERATE_SERIALIZATION’
715 | #define PARSE_ARGS GENERATE_LOGO;GENERATE_XML;GENERATE_TCLAP;GENERATE_DESERIALIZATION;GENERATE_ECHOARGS;GENERATE_ProcessInformationAddressDecoding;GENERATE_SERIALIZATION;
| ^~~~~~~~~~~~~~~~~~~~~~
/home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:5:3: note: in expansion of macro ‘PARSE_ARGS’
5 | PARSE_ARGS;
| ^~~~~~~~~~
In file included from /home/matt/src/jsoncpp/include/json/json.h:13,
from /home/matt/src/SlicerExecutionModel/ModuleDescriptionParser/JsonSerializationUtilities.h:18,
from ./CLPExample1CLP.h:15,
from /home/matt/src/itk-js/test/CLPExample1/CLPExample1.cxx:1:
/home/matt/src/jsoncpp/include/json/writer.h:298:5: note: declared here
298 | StyledStreamWriter {
| ^~~~~~~~~~~~~~~~~~
jcfr
reviewed
Dec 31, 2020
There was a problem hiding this comment.
Since ensuring the developer have the same ITK build tree is important is the general case, should we test for CMAKE_CROSSCOMPILING variable ?
|
This is not only useful for cross-compiling -- in general different ITK version or build configuration may be desired for the generated CLI. |
|
@jcfr Any other comments on this? Is it OK as is? |
|
Thanks for the feedback. After further consideration, the proposed changes make sens. |
jcfr
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.