ENH: Let user turn ON/OFF collision detection #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many laptops, the algorithm eats up a lot of RAM and freezes the computer for some seconds. So disable it by default, and only turn it on actively by the user, so that he sees why this is happening. In some cases, we do not want to calculate collisions, just to play around and show functionality as well as quickly visually see where there might be collisions. Once beam angle is decided, we can activate numerical collision detection, and get more accurate results.
ferdymercury
force-pushed
the
colldetbox
branch
from
4bde7ce to
45d1f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpinter: In many laptops, the algorithm eats up a lot of RAM and freezes the computer for some seconds. So disable it by default, and only turn it on actively by the user, so that he/she sees why this is happening. Also, this change is fundamental since the collision detection is, at the moment, freezing the GUI rather than running in the background.
In some cases, we do not want to calculate collisions, just to play around and show functionality as well as quickly visually see where there might be collisions. Once beam angle is decided, we can activate numerical collision detection, and get more accurate results.
Thanks in advance for the review!