Add Positional UDP packet #1546
Conversation
adds positional UDP packet
SummerSigh
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
github-actions
bot
added
Area: Hardware Protocol
|
Mind making a PR to this file? https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/main/src/network/packets.h#L56 Just reserving the enum 27 would be fine |
🚀 🚀 🚀 🚀 🚀 🚀
|
🚀 |
| tracker = connection?.getTracker(packet.sensorId) | ||
| if (tracker == null) return | ||
| tracker.position = packet.position | ||
| // dont call dataTick here as this is just position update |
There was a problem hiding this comment.
Why we don't do data tick here? We need to update stuff based on new position though?
We also should probably have a PositionRotation packet that has both to save on a bit of data
There was a problem hiding this comment.
me and butter talked about this a bit. essentially data tick has filtering stuff (specific to rotation data) that happens when it's called and is otherwise only really used to calculate TPS. PositionRotation is something that could be added for sure, but i was just going to use packet bundling anyway to do rot + pos in a single packet. Can add to this PR if needed
CC @ButterscotchV
No description provided.