Skip to content

Use labels for keyboard profile #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions drivers/SmartThings/matter-switch/profiles/12-button-keyboard.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: 12-button-keyboard
components:
- id: F1
- id: main
label: F1
capabilities:
- id: button
version: 1
Expand All @@ -10,67 +11,78 @@ components:
version: 1
categories:
- name: RemoteController
- id: F2
- id: button2
label: F2
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F3
- id: button3
label: F3
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F4
- id: button4
label: F4
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F5
- id: button5
label: F5
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F6
- id: button6
label: F6
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F7
- id: button7
label: F7
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F8
- id: button8
label: F8
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F9
- id: button9
label: F9
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F10
- id: button10
label: F10
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F11
- id: button11
label: F11
capabilities:
- id: button
version: 1
categories:
- name: RemoteController
- id: F12
- id: button12
label: F12
capabilities:
- id: button
version: 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ local mock_device = test.mock_device.build_test_matter_device({

local function configure_buttons()
for key = 1, 12 do
local component = "F" .. key
local component = "button" .. key
if key == 1 then component = "main" end
test.socket.capability:__expect_send(mock_device:generate_test_message(component, capabilities.button.supportedButtonValues({"pushed"}, {visibility = {displayed = false}})))
test.socket.capability:__expect_send(mock_device:generate_test_message(component, capabilities.button.button.pushed({state_change = false})))
end
Expand Down Expand Up @@ -233,7 +234,7 @@ test.register_coroutine_test(
clusters.Switch.events.InitialPress:build_test_event_report(mock_device, key, {new_position = 1})
})
test.socket.capability:__expect_send(
mock_device:generate_test_message("F" .. key, capabilities.button.button.pushed({state_change = true}))
mock_device:generate_test_message(key == 1 and "main" or "button" .. key, capabilities.button.button.pushed({state_change = true}))
)
end
end
Expand Down
12 changes: 6 additions & 6 deletions drivers/SmartThings/matter-switch/src/third-reality-mk1/init.lua
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ local function endpoint_to_component(device, ep)
return component
end
end
return "F1"
return "main"
end

-- override subscribe function to prevent subscribing to additional events from the main driver
Expand All @@ -58,12 +58,12 @@ local function configure_buttons(device)
local ms_eps = device:get_endpoints(clusters.Switch.ID, {feature_bitmap=clusters.Switch.types.SwitchFeature.MOMENTARY_SWITCH})
for _, ep in ipairs(ms_eps) do
if device.profile.components[endpoint_to_component(device, ep)] then
device.log.info_with({hub_logs=true}, string.format("Configuring Supported Values for generic switch endpoint %d", ep))
device.log.info(string.format("Configuring Supported Values for generic switch endpoint %d", ep))
local supportedButtonValues_event = capabilities.button.supportedButtonValues({"pushed"}, {visibility = {displayed = false}})
device:emit_event_for_endpoint(ep, supportedButtonValues_event)
device:emit_event_for_endpoint(ep, capabilities.button.button.pushed({state_change = false}))
else
device.log.info_with({hub_logs=true}, string.format("Component not found for generic switch endpoint %d. Skipping Supported Value configuration", ep))
device.log.info(string.format("Component not found for generic switch endpoint %d. Skipping Supported Value configuration", ep))
end
end
end
Expand All @@ -72,9 +72,9 @@ local function build_button_component_map(device)
local button_eps = device:get_endpoints(clusters.Switch.ID, {feature_bitmap=clusters.Switch.types.SwitchFeature.MOMENTARY_SWITCH})
table.sort(button_eps)
local component_map = {}
for component_num, ep in ipairs(button_eps) do
local button_component = "F" .. component_num
component_map[button_component] = ep
component_map["main"] = button_eps[1]
for component_num = 2, 12 do
component_map["button" .. component_num] = button_eps[component_num]
end
device:set_field(COMPONENT_TO_ENDPOINT_MAP, component_map, {persist = true})
end
Expand Down
Loading