feat:TCM-5729: Allow JSON translations in the Smartling Translate #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add json file type switch fileType field to String (clients could use new values without upgrading sdk lib)
ksoloviov-smartling
requested review from
RRagnar,
andy-radchenko and
klegins-smartling
as code owners
revert fileType field to String (clients could use new values without upgrading sdk lib) by Max request
revert fileType field to String (clients could use new values without upgrading sdk lib) by Max request
klegins-smartling
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add json file type
switch fileType field to String (clients could use new values without upgrading sdk lib)