Reduce requirements for task metadata relative to graph metadata pb wrapper #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmontemayor2-sc
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
nit. this file should be template_config_checks_test.py?
Comment on lines
+8
to
+9
| DEFAULT_HOMOGENEOUS_GRAPH_METADATA_PB, | ||
| DEFAULT_HOMOGENEOUS_NODE_TYPE_STR, |
There was a problem hiding this comment.
unrelated, this shouldn't be done in this pr.
We should not have mutable constants like this [1]. If we do this, then one test could mutate them, and have other downstream tests fail.
Ideally, we have some create_graph_metadata_pb() that always creates a new object.
Can we add this to some task tracker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of work done
Reduces the restrictions of our task metadata to only enforce that the source and destination node types of the supervision edge types are in the graph metadata, rather than the edge types as well. This can unblock use cases where we may have
A -> B,B -> Bas graph metadata edge types butB -> Aas our supervision edge type.Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO