Skip to content

Fix: 40w laser crosshair offset when Run from Luban #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlmirKadric
Copy link

Currently the required custom G-Codes (M2003 and M2004) which offset the 20w & 40w lasers to align their crosshairs, are not implemented on the controller side. This results in the jobs using the 20w & 40w lasers to be shifted to the right when "Run from Luban". When checking the controller (LCD panel), there was a section in the laser configuration for these values and it is being handled correctly when a G-Code file is run directly from the controller (LCD).

To temporarily alleviate this issue, I introduced a moduleOriginOffset feature which enables us to define module specific origin offsets within the machine definition files. I also introduced a new module definition for the crosshair so that it can ben controlled from the machine settings window. Lastly I hardcoded a default crosshair offset.

Potential Improvements:

  • make the offset values configurable rather than hardcoded

added moduleOriginOffset feature to machine definitions and setup a default crosshair offset
@AlmirKadric
Copy link
Author

Will address some of the issues in #2377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant