Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found after integration tests #79

Merged
merged 29 commits into from
Mar 25, 2025
Merged

Fix issues found after integration tests #79

merged 29 commits into from
Mar 25, 2025

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Mar 12, 2025

This PR fixes issues found after integration tests:

  • GenericStreamingGraphBuilder moved from the base directory.
  • Added the @Obsolete annotation to the generic BatchProcessor class.
  • Added missing dependencies.

Copy link

github-actions bot commented Mar 12, 2025

File Coverage
All files 72%
logging/ZIOLogAnnotations.scala 76%
models/ArcaneSchema.scala 92%
models/DataCell.scala 0%
models/DataCell.scala 0%
models/ArcaneSchema.scala 0%
models/DataCell.scala 71%
models/app/StreamContext.scala 0%
models/cdm/SimpleCdmModel.scala 88%
models/cdm/CdmParser.scala 89%
models/cdm/CdmParser.scala 93%
models/querygen/MergeQuerySegment.scala 88%
models/querygen/MergeQuerySegment.scala 85%
models/querygen/MergeQuery.scala 85%
models/querygen/InitializeQuery.scala 0%
models/settings/TablePropertiesSettings.scala 98%
services/app/StreamRunnerServiceImpl.scala 0%
services/app/PosixStreamLifetimeService.scala 0%
services/cdm/CdmTableStream.scala 57%
services/cdm/CdmSchemaProvider.scala 90%
services/cdm/AzureBlobStorageReaderExtensions.scala 83%
services/cdm/SynapseHookManager.scala 95%
services/cdm/CdmTableStream.scala 83%
services/consumers/SqlServerChangeTracking.scala 86%
services/consumers/SqlServerChangeTracking.scala 90%
services/filters/FieldsFilteringService.scala 90%
services/hooks/manager/EmptyHookManager.scala 0%
services/hooks/manager/EmptyHookManager.scala 0%
services/lakehouse/IcebergS3CatalogWriter.scala 78%
services/lakehouse/SchemaConversions.scala 28%
services/lakehouse/IcebergCatalogCredential.scala 56%
services/merging/JdbcMergeServiceClient.scala 35%
services/merging/MutableSchemaCache.scala 97%
services/merging/JdbcMergeServiceClient.scala 94%
services/mssql/MsSqlDataProvider.scala 71%
services/mssql/MsSqlDataProvider.scala 68%
services/mssql/MsSqlStreamingDataProvider.scala 85%
services/mssql/QueryProvider.scala 77%
services/mssql/MsSqlConnection.scala 82%
services/mssql/MsSqlHookManager.scala 0%
services/mssql/query/ScalarQueryResult.scala 66%
services/mssql/query/LazyQueryResult.scala 79%
services/storage/models/amazon/AmazonS3StoragePath.scala 80%
services/storage/models/azure/AdlsStoragePath.scala 81%
services/storage/models/azure/AzureModelConversions.scala 98%
services/storage/services/AzureBlobStorageReader.scala 65%
services/streaming/base/StreamGraphBuilder.scala 0%
services/streaming/graph_builders/backfill/GenericBackfillOverwriteGraphBuilder.scala 81%
services/streaming/graph_builders/backfill/GenericBackfillMergeGraphBuilder.scala 83%
services/streaming/processors/batch_processors/backfill/BackfillApplyBatchProcessor.scala 87%
services/streaming/processors/batch_processors/backfill/BackfillDisposeBatchProcessor.scala 0%
services/streaming/processors/batch_processors/streaming/DisposeBatchProcessor.scala 68%
services/streaming/processors/transformers/StagingProcessor.scala 93%
services/streaming/processors/transformers/FieldFilteringTransformer.scala 70%
utils/SqlUtils.scala 50%

Minimum allowed coverage is 40%

Generated by 🐒 cobertura-action against cd0e797

# Conflicts:
#	src/main/scala/services/mssql/MsSqlStreamingDataProvider.scala
# Conflicts:
#	src/main/scala/services/streaming/base/BatchProcessor.scala
#	src/main/scala/services/streaming/base/StagedBatchProcessor.scala
# Conflicts:
#	src/main/scala/services/streaming/base/BatchProcessor.scala
#	src/main/scala/services/streaming/graph_builders/GenericStreamingGraphBuilder.scala
#	src/test/scala/services/streaming/GenericStreamRunnerServiceTests.scala
#	src/test/scala/services/streaming/processors/MergeBatchProcessorTests.scala
# Conflicts:
#	src/test/scala/services/streaming/GenericStreamRunnerServiceTests.scala
# Conflicts:
#	src/main/scala/services/streaming/base/BackfillStreamingGraphBuilder.scala
@s-vitaliy s-vitaliy changed the title Integration tests fixes Fix issues found after integration tests Mar 25, 2025
@s-vitaliy s-vitaliy marked this pull request as ready for review March 25, 2025 11:27
@s-vitaliy s-vitaliy merged commit b27ba4c into main Mar 25, 2025
2 checks passed
@s-vitaliy s-vitaliy deleted the fixes-2 branch March 25, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants