feat(vex): manifest-less VEX from hosted/vendored lockfiles + npm 12 allow-remote auto-config (v5) - #251
feat(vex): manifest-less VEX from hosted/vendored lockfiles + npm 12 allow-remote auto-config (v5)#251Mikola Lysenko (mikolalysenko) wants to merge 9 commits into
Conversation
First of seven commits that land the manifest-less VEX branch (feat/vex-lockfile-inventory) on top of #247. The branch's ~165-commit history, built on the pre-#247 main 9489b18 with per-PM merge commits, was squashed onto 09956d9 and re-split by concern; the full pre-rebase history is preserved on branch backup/vex-lockfile-pre-rebase. These are the product bugs the per-PM real-toolchain matrices turned up while the manifest-less VEX suites were written. Each is independent of VEX and pinned by a core regression test: - composer (hosted): the rewriter drops the entry's `source` block when it immediately precedes `dist` (one `redirect_composer_dist` fragment edit spanning both, reverted byte-for-byte). Composer 1 and 2.2 LTS silently installed the pristine upstream commit from git whenever the hosted download failed; a hand-ordered source that cannot be dropped warns `redirect_composer_source_kept`. Golden fixture: `source-and-dist`. - gem (hosted): the patch-registry `GEM` section is inserted in bundler's source order (sorted by remote), so a frozen `bundle install` on bundler >= 4.0.19 accepts the converged lock. The `basic` golden and the exact lock expectations move the Socket section first. - cargo (hosted + vendored): a v1 `Cargo.lock` (checksums in `[metadata]`, dependents naming the crate by its full package id) is redirected and vendored correctly: the `[metadata]` line and every dependent's full-id reference follow the source, each fragment its own ledger edit, and `cargo --locked` accepts the result; the vendored detach/restore of a v1 entry is byte-identical. `plan_cargo_lock` keeps #247's multi-source twin disambiguation (`Ambiguous`) and hoisted regexes; the block end now also stops at a trailing `[metadata]` / `[[patch.unused]]`, and the checksum is inserted after a block-final `source` line too. - yarn berry (hosted + vendored): written checksums follow the lock's own spelling — yarn 4.0.0–4.0.2 spell `10c0` checksums as bare hex, so the prefixed form failed `yarn install --immutable` with YN0028. - npm (vendored): npm 12 reifies from the `package-lock.json` it creates beside a committed shrinkwrap, so `vendor` now rewires every present npm lock (siblings first, primary last; an unrewirable sibling warns `vendor_npm_sibling_lock_unwired`), and the in-use/revert probes read every npm lock before deleting an artifact. `select_lockfile` reads through #247's guarded `read_regular_to_bytes`. - npm (hosted): a lockfileVersion 1 redirect warns `redirect_npm_legacy_client` — npm 6 ignores a v1 lock's `resolved` and fails EINTEGRITY against the patched pin. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
npm >= 12 defaults to `allow-remote=none` and refuses (EALLOWREMOTE) every
lockfile entry whose tarball is not served by the configured registry —
exactly what a hosted redirect writes. When `scan --mode hosted` / `get
--mode hosted` leaves a root package-lock.json / npm-shrinkwrap.json
carrying a granted hosted artifact URL, the run now ensures
`allow-remote=all` in the project `.npmrc` (creating the file, or
appending one line with the BOM, CRLF and every other byte preserved) and
records it in the redirect ledger as `redirect_npmrc_allow_remote`
(`created` / `added`).
- core `patch::redirect::npmrc`: npm's `.npmrc` grammar as measured
against npm 12.1.0 (exact `allow-remote` key, last top-level assignment
wins, `[section]` bodies are not top-level, bare-CR line splits, case-
sensitive value), the plan (create / append / already-all / respected
user / env / outer-layer value / unsupported), and the unwinds.
- Every reversal removes exactly what was added once no package-lock
entry needs it: the whole-ledger replay (a new `NpmrcAllowRemote`
inverse, grouped with the npm lock kinds), the per-purl npm revert
behind scoped rollback / remove / the vendored takeover ("last one
out", same transaction, flushed after the lock through #247's shared
`staged::flush_staged`), and the vendored-supersedes-hosted reconcile.
A modified created file keeps the user's lines
(`redirect_npmrc_allow_remote_modified`, surfaced by rollback, remove,
vendor and the reconcile). A symlinked `.npmrc` refuses an unwind at
plan time, before anything is written.
- Hosted run: the `.npmrc` edit rides `rewrite.files` / `rewrite.edits`,
so it is written under #247's apply-lock window, after its whole-run
SYMLINK GUARD, and only after the ledger persisted — never on
`--dry-run` (which previews the write, also for a vendored → hosted
takeover; the root locks are now read for such a preview so the pnpm
`trustLockfile` preview sees the lock the wet run splices). An explicit
user value (project `.npmrc`, user/global/builtin config, or an
`npm_config_allow_remote` env var) is respected and named; a symlinked,
unreadable or bare-CR `.npmrc` is left alone; `--no-npm-allow-remote-
config` / `SOCKET_NO_NPM_ALLOW_REMOTE_CONFIG` opts out. Every variant
warns `redirect_npm_allow_remote` with the whole-tree tradeoff.
- `atomic_write_bytes_preserving_mode` creates its stage with the
destination's permission bits (kept inside #247's `commit_stage`
structure), so a 0600 token-bearing `.npmrc` is never staged world-
readable.
- remove: the hosted leg's advisories are printed inside #247's
`unwind_hosted` (so a run that then fails still reports them) and carried
into the success envelope's `warnings[]`.
Tests: npmrc/replay/takeover/scan unit tests, the flag's parse coverage,
`redirect_npm_allow_remote` (plus #247's invariants: the lock never
outlives the run, dry runs create no `.socket/`, a full rollback leaves no
`.socket/` and never the user's `.npmrc`), and the dry-run takeover
previews in `coverage_fix_scan_hosted_dryrun_vendored`.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A verbatim move with no behavior change, so the next commit can give each lock format its shared entry model beside its registry view: `vendor/lock_inventory.rs` becomes a directory module with one file per format (`npm`, `npm_family`, `pnpm`, `yarn`, `bun`, `cargo`, `golang`, `composer`, `gem`, `pypi`), ledger recovery (`recover`) and the rewired-lock trust anchor (`wired`). `mod.rs` keeps the public API (`LockIntegrity`, `LockfileEntry`, `UnsupportedNpmLayout`, `lookup`, `inventory_project(_diagnosed)`, `recover_lock_entry`, `wired_vendor_integrity`); the three test modules move to `tests.rs`, `recover_tests.rs` and `python_lock_union_tests.rs`. Only imports, visibility (helpers another file calls become `pub(super)`), sibling-module paths (`super::state` -> `crate::vendor::state`), module docs and the single-file section banners changed; the test modules lost one indentation level and were re-wrapped by rustfmt. `git show --color-moved` shows everything else as moved. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ckfiles
New read-only module `vex::discover`: `discover_patched_refs(_with)`
reads every supported ROOT lockfile / package-manager config and returns
the Socket patch wiring it finds — `Discovery { refs, diagnostics,
recognized, unlocked_pins, elsewhere }`, one `PatchedRef { purl, uuid, mode
(Hosted | Vendored), source_file, artifact_rel, locked_integrity,
integrity_required, url }` per live reference. It never touches the
network, never writes, and never fails the run: a malformed file is a
diagnostic (`lockfile_unreadable`, `lockfile_unparseable`,
`patched_ref_invalid`, `patched_ref_unattributable`).
One extractor per package-manager family: npm (package-lock /
shrinkwrap, pnpm every lock generation + Rush locks), yarn classic and
berry, bun (`bun.lock` / `bun.lockb`), cargo, golang (go.mod / go.work +
sums), pypi locks (uv, PEP 723 script locks, pylock, poetry, pdm), pypi
other (Pipfile.lock, requirements + `-r`, Hatch / PEP 621 direct refs),
gem, composer, maven, nuget; deno is explicitly empty. Every file present
is read — no precedence chain — because the hosted rewriter edits every
candidate it finds.
Every value is committed, tamperable data and is validated fail-closed:
- hosted: `hosted_patch_uuid` accepts only `https://patch.socket.dev` or
a configured `--patch-server-url` origin, no userinfo, and takes the
LAST canonical-uuid path segment (grant tokens may be uuid-shaped);
percent-encoding, `\/` escapes and fragments are handled;
- vendored: root-anchored `.socket/vendor/<eco>/<uuid>/…` paths whose
leaf names the entry's own artifact (`vendor_ref` takes the path
literally; only yarn / URL-form pip strip their `#…` / `::…` decorations);
- pins, not definitions: a registry / index / source definition alone
(cargo `[registries]`, nuget `<add>`, pom `<repository>`, uv index
tables, `.npmrc`) never makes a reference;
- contested locks: a lock that resolves the same name@version from a
non-Socket source drops the ref (`patched_ref_unattributable`);
- lockless cargo pins / exclusive nuget mappings are recorded as
`UnlockedPin`s that can only keep a ledger record live, never create a
ref; `recognized` lists every uuid a read file mentions, so a rejected
mention keeps nothing alive downstream.
Supporting core changes: `patch::redirect::{SOCKET_PATCH_SERVER_HOST,
hosted_patch_uuid, hosted_patch_url_uuids}` (the pipenv owner check uses
the shared host constant); the pnpm lock grammar and `hosted_url_version`
exported crate-wide so readers parse exactly what the writers write;
`utils::digest` (the SRI pin rule and the hex digest shapes — one copy for
the inventory, discovery, ledger recovery and the rewriters, each call
site keeping its case policy); and `utils::purl`'s validating purl
builders, which discovery and the inventory's registry views share. A few
writer helpers become `pub(crate)` so the extractors' tests derive their
fixtures from the writers themselves.
One lockfile traversal layer: discovery and `vendor::lock_inventory` (the
scan / get / vendor / repair inventory) read each format through ONE
reader that yields every entry, Socket-owned ones included — the
inventory's registry views drop those, the extractors classify them:
- `lock_inventory` becomes a directory module, one file per format, each
laid out as a pure entry model, a stat-only file-selection section and
the registry view (an architecture test enforces the layering). Entry
models: `npm_lock_nodes`; `pnpm_packages` over the hosted rewriter's
pnpm grammar (every key generation, CRLF included); the yarn
`classic_entries` / `berry_entries` models with one berry locator,
cache-key and checksum rule; `BunLockb::parse_packages`; and
`composer_lock_packages`, whose array index the composer writer's lock
walks use too.
- Every other format reads through the reader its writer owns:
`cargo_lock::locked_packages` and `cargo_config`'s `[patch]` /
`[registries]` walks; `go_mod_edit` / `go_sum_edit` read helpers; a new
`vendor::gemfile_lock` model; the `utils::python_lock` / `poetry_lock` /
`hatch` readers (uv source fields, script-lock pairing, the pyproject /
Hatch declaration walk); a new `utils::requirements` lexer lifted out of
the vendored requirements planner; and two new XML readers,
`vendor::maven_pom` and `vendor::nuget_config`, with
`nuget_feed::nuget_lock_entries` shared by discovery and the feed
writer.
- `DiscoverCtx::locate` classifies a lock location once (vendored path,
hosted uuid, decorated leaf) for every extractor. The npm-family
extractors iterate the entry models only, never the grammar primitives,
and every extractor reads content only through the recognizing ctx
(rule 11) — both enforced by architecture tests.
Ledger liveness is one rule too: `Discovery::{wires_package,
vendor_entry_live, redirect_record_live}`, held per call site by
`LedgerLiveness` (the sorted redirect-ledger files, the lock inventory
loaded lazily at most once), which the CLI's vex and scan both use. Cargo
crates.io provenance is explicit (`LockfileEntry::source_kind`), not
inferred from the checksum variant.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…m lockfiles `socket-patch vex` and the embedded `apply` / `scan` / `vendor --vex` now attest hosted and vendored patches with no `.socket/manifest.json` — and with no `.socket/vendor` ledgers either — by reading the wiring out of the project's lockfiles (`vex::discover`). This covers a depscan-opened PR, a clone that never committed its ledgers, and a lock-only CI checkout. Record view (`commands::vex_sources::plan`): four sources — the manifest, the redirect ledger's records, the vendor ledger's embedded records and lockfile discovery — merge into one view. A candidate's record must carry the uuid the lockfile actually WIRES; it comes from the first source that has one, else (online only) from the patch API by uuid, 10 fetches at a time with `get`'s one-shot 401/403 → public-proxy fallback (#247's uuid-only `ApiClient::fetch_patch`). Nothing is written: vex never takes the apply lock, never creates `.socket/`, never writes the manifest, and the `socket-patch.vendor.json` marker is never a record. Gates, applied before hashing and kept under `--no-verify` (which now skips only the hashing): - a vendor-ledger entry attests only while a lockfile still wires its artifact (`vendor_unwired`); a redirect-ledger record only while a lockfile wires its hosted patch (`redirect_unwired`); discovery is authoritative for every uuid a read file mentions, so a rejected mention keeps nothing alive; - `record_unavailable` (offline, 404, refused, transport error — the run continues), `record_mismatch`, `wiring_conflict` (lockfiles wire one package to several patches); - a malformed / unreadable `.socket/vendor/state.json` is the hard error `vendor_ledger_corrupt` (exit 2), mirroring `redirect_ledger_corrupt` — this supersedes #247's degrade-and-disclose posture for `vex` only; `setup --check` keeps #247's `vendor_context_from` / `warn_unreadable_vendor_state` path. Evidence: vendored refs hash the committed artifact (the ledger entry when it names the wired artifact, else one synthesized from the ref); hosted refs hash the installed copies the build CONSUMES (`vex_consumed::hosted_consumed_copies` → core `VendorContext::hosted` / `HostedCopies`: the Go replacement module, the Socket-registry cargo src dir, maven's suffixed version — never a pristine sibling), and with nothing installed a discovered pinned reference attests from its lockfile pin, like in-run `scan --mode hosted --vex`. Discovered refs bypass the Property 7 ecosystem filter. Commands: - `apply --vex` / `vendor --vex` with no manifest attest what the lockfiles and ledgers wire (nothing anywhere keeps the calm exit 0 and removes a stale document; `apply --check` and `--dry-run` never generate); #247's no-manifest lines ("No patch manifest found; nothing to apply.", "No manifest found, nothing to vendor.") are kept; - failed VEX runs carry the discovery diagnostics into `warnings[]` (standalone envelope, embedded envelopes, scan JSON — hosted included); - `manifest_not_found` now means no manifest AND nothing wired; - human output: `Note:` lines for superseded records / fetch failures, phrased omission reasons. Writer hardening: the manifest-driven standalone `vendor` now embeds the patch `record` in its ledger entries too (vendored mode already does, as `detached` entries). `detached` stays the "no manifest owner" flag, so the manifest reconcile, legacy-manifest migration and get/scan idempotency from #247 are unaffected. Every reader of embedded records shares one ownership rule (`commands::vendor_record_is_unowned`): a detached entry's record always stands alone, a standalone `vendor` entry's fallback copy only when no manifest entry covers it (by ledger key or base purl). `vex`, `list` and `setup --check` (`fold_vendor_records`, formerly `fold_detached_records`) all apply it, so one tree never lists "no patches" while its VEX document attests one. `repair` stays narrower: it keeps preferring a manifest that moved on to a newer uuid and falls back to the embedded copy only with no manifest at all. One liveness rule for vex and scan: `scan`'s cross-mode takeover classification (`classify_overlap_takeover`), its `hosted_wiring_retained` warning and `redirectState.wiringLive` ask the same core discovery (`commands::discover_wiring`) and liveness rule (`Discovery::redirect_record_live` / `vendor_entry_live` / `wires_package`, through one `LedgerLiveness` holder per call site) that gate attestation, replacing scan's private cargo / hosted / vendored checks and its looser text scan. The CLI also shares one purl splitter (`utils::purl::purl_parts`), one vendor-ledger lookup (`vendor::state::lookup_entry_kv`) and one npm alias-aware identity crawl (`ecosystem_dispatch::npm_paths_by_identity`) across vex, scan and vendor, and pairs PEP 723 script locks through `utils::python_lock::script_of_lock` like the rewriters do. Output follows the conventions from #248: `ui::plural` counts, a `ui::StatusLine` progress line for record fetches, and the shared `format_vex_written` / `format_vex_dry_run_skip` lines on the manifest-less `apply --vex` / `vendor --vex` paths. Manifest-less `vex` honours `--dry-run` and `-O -` like the manifest path. Product auto-detection adds go.mod, composer.json, pom.xml, a single `*.csproj` and a single `*.gemspec`, after the existing probes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…pers
Hermetic suites (wiremock patch API, run in the default `test` job on
every OS): one `e2e_vex_lockfile_<pm>` per package manager — npm, pnpm,
yarn (classic + berry), bun, cargo, golang, uv, poetry, pdm, hatch,
pipenv, pip, gem, composer, maven, nuget, deno (negative) — covering
spoofed hosts, record mismatch, pristine / tampered installs, contested
and orphaned wiring, `--offline`, reverted locks (also `--no-verify`) and
the embedded commands; plus the cross-cutting `e2e_vex_manifestless_
embedded`, `e2e_vex_redirect`, `e2e_vex_vendor` and the
`vex_e2e_common_selftest` harness checks.
Real-PM capstones (gated like the existing suites, `_REQUIRED` env
pattern): every hosted / vendored build suite now ends in the manifest-
less VEX matrix over a fresh checkout — manifest absent (ledgers kept),
ledgers deleted (lockfile + API), offline (`record_unavailable`, zero
requests), reverted lock (never attested, verify or not) — through shared
helpers: `vex_e2e_common` (+ bun / uv matrices), `npm_e2e_common`
(+ `manifestless`), `yarn_berry_common`, `common/yarn_classic_vex`,
`common/bundler_e2e`, `cargo_e2e_matrix`, `golang_e2e_matrix`,
`maven_build_common`, `composer_e2e_common`, `vex_pdm_hatch_common`,
`vex_pipenv_pip_*`, `vex_pypi_real_common`. New real-toolchain suites:
`e2e_redirect_{composer,maven,uv}_build`, `e2e_vendor_maven_build`,
`e2e_golang_workspace_build`, `e2e_nuget_dotnet_build`,
`e2e_poetry_vex_build`, `e2e_vex_{pdm,pip,pipenv,hatch}_build`,
`e2e_deno_vex_build`; the docker / setup-matrix / production legs gain
their manifest-less VEX steps.
Re-pinned to #247 while rebasing:
- vendored mode writes no manifest: the "manifest deleted" steps are
naturally manifest-free, so the npm manifest-less matrix and the uv /
poetry vendored suites add a `legacy-manifest` cell (the record a
pre-5.0 vendored run left beside its ledger, via
`vex_e2e_common::seed_legacy_manifest`, must attest the same way), the
yarn 2/3 refusal suite seeds that legacy record explicitly (and still
requires `not_applied`, never an attestation), and `--detached` twins
assert no manifest in either spelling;
- a fully reverted project keeps no `.socket/`: suites that plant a stale
ledger back after a rollback recreate the directory first, and the
hosted rollback suite checks that `vex` does not recreate it;
- the no-manifest human lines follow #247's wording;
- a corrupt vendor ledger on a manifest-free project is now
`vendor_ledger_corrupt` (exit 2, the ledger named, never rewritten),
replacing #247's disclose-then-`manifest_not_found` expectation;
- repair: two tests pin the standalone-`vendor` embedded record (a
moved-on manifest still wins; with no manifest the embedded copy stands
in offline), replacing the pre-rebase test that assumed a non-detached
`scan --vendor` entry.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ci.yml:
- `test` exports `SOCKET_PATCH_GO_E2E_REQUIRED` / `_VERSION` so the
real-go hosted/vendored suites fail instead of skipping on the Go that
is already installed for vexctl;
- `e2e` gains pinned-toolchain legs, each ending in the manifest-less VEX
matrix: composer 1 / 2.2 / 2 (hosted + vendored), bundler 1.17.3 →
4.0.21 (hosted + vendored + setup_matrix_gem), bun text/binary-lock
eras, the named corepack pnpm legs (3 OS), uv 0.1.45 → 0.12.x hosted +
vendored, poetry / pdm / hatch / pipenv / pip, maven 3.6.3 → 4.0.0-rc-6,
dotnet 6 → 10, deno; npm legs hard-require npm where
`Command::new("npm")` can resolve it;
- new jobs: `yarn-classic-matrix` (1.0.2 → 1.22.22), `yarn-berry-e2e`
(4.0.2 → 4.18.0 + macOS/Windows), `cargo-vex-matrix` (toolchains ×
Cargo.lock v1–v4); `e2e-docker` also runs the pypi vendored-PM suite.
Compatibility workflows: npm (npm 6–12 capstones, new), go (1.18.10 →
1.26.3, new), poetry (new), and the pnpm / pdm / pipenv / bun ones run
the manifest-less VEX steps and trigger on the vex sources. The bun
workflow keeps #247's two modes (hosted, vendored — the vendored-
detached leg collapsed into vendored).
Scripts: the bun / pdm / pipenv / poetry / uv backtests gain the
manifest-less VEX checks (a fresh checkout of the committed state must be
attested, also with the ledgers deleted; `--offline` with no ledger omits
`record_unavailable`; a reverted lock never attests, also under
`--no-verify`; a refused lock format attests nothing — the pdm refusal
check follows #247's manifest-free footprint), plus the
`{uv,yarn-berry,yarn-classic}-vex-matrix.sh` drivers and harness unit
tests.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- CHANGELOG [Unreleased] (both entries are v5 MAJOR): the semver note now lists #247's changes and `vex` refusing stale ledger records and corrupt vendor ledgers; Changed (BREAKING) gains the ledger-liveness / `vendor_ledger_corrupt` entry (and #247's Fixed bullet that had `vex` disclose an unreadable ledger now points at it); Added gains the npm 12 `allow-remote` auto-config, manifest-less VEX, standalone `vendor` record embedding and the new product probes; Fixed gains the composer / gem / cargo v1 / yarn 4.0 / npm dual-lock rewriter fixes after #247's own entries. - CLI_CONTRACT.md: new "Manifest-less VEX (lockfile discovery)" section (inputs, per-ecosystem recognition table, record resolution, verification basis, liveness gates, run warnings), "Patch hosts", the embedded-VEX no-manifest rules, `manifest_not_found` for `vex`, the vendor ledger's `record` semantics (vendored-mode `detached` entries plus the standalone `vendor` fallback copy; the reconcile exemption keys on `detached`), and the new rollback warning code. - README: "No manifest needed for hosted and vendored patches", the rewritten `vex` how-it-works steps and product probes, "npm compatibility (hosted mode and npm 12)", the hosted `.npmrc` commit hint, and the ledger-liveness note under "Undo things". - docs/testing: npm-compatibility.md (npm 6–12, new), uv and bun tables, ecosystems.md. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Pin the exact output of lockfile discovery over every committed fixture project, so a behavior change to discovery (or to the lock readers it shares with the rewriters and vendor::lock_inventory) shows up as a golden diff to review. - Corpus: 182 projects under crates/socket-patch-core/tests/fixtures/ — every redirect case's input/ and expected/ tree, pnpm-hosted, poetry, pipenv, bun-lockb captures, and each pdm-native lock staged as pdm.lock — run through the full orchestrator and checked against rule 11's recognition-covers-refs invariant. - Rendering (src/vex/discover/testing/golden.rs): every PatchedRef field (plus lockfile_basis_ok), diagnostics (tempdir root and OS error numbers normalized), recognized identities, unlocked pins, resolved-elsewhere entries, and the live hosted / vendored ledger claims. The destructuring is exhaustive, so a new field fails to compile until the golden covers it. - Goldens: one JSON per fixture family (redirect-<eco>, bun-lockb, pdm-native, pipenv, pnpm-hosted, poetry) under tests/fixtures/vex-discover-golden/, mapping fixture path to output. Missing and orphaned entries fail. Regenerate after an intended change with SOCKET_PATCH_UPDATE_GOLDEN=1 cargo test -p socket-patch-core --lib vex::discover::testing::golden. Unix only: Windows checkouts convert some fixtures' line endings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit faf9ed3. Configure here.
| }) | ||
| .collect(); | ||
| all.extend(npm_paths_by_identity(options, &missing).await); | ||
| } |
There was a problem hiding this comment.
Workspace npm aliases skip VEX hashing
Medium Severity
Hosted npm VEX claims every consumed copy is hashed, but the alias walk only starts at the root node_modules and never visits workspace-member trees. The identity fallback that would find those aliases runs only when no copy was found at all, so a root or hoisted install causes member aliases to be skipped. A stale or tampered workspace alias can then stay unhashed while the document attests from the good copy.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit faf9ed3. Configure here.
| "{}: {what}: impact {impact:?} lacks {part:?}", | ||
| self.leg |
| let impact = st["impact_statement"].as_str().unwrap_or_default(); | ||
| assert!( | ||
| impact.split("; ").any(|p| p == part), | ||
| "{leg} ({cell}): impact {impact:?} lacks {part:?}" |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|


Branch
feat/vex-lockfile-inventory: 9 logical commits onmain@15a6ba6(#247 + #248); 272 files, +93.7k / −8.3k. The verbatimlock_inventorysplit (commit 3) accounts for 5.4k of each side, and most of the rest is tests.Summary
socket-patch vex, and the VEX thatapply/scan/vendor --vexgenerate, now attest hosted and vendored patches with no.socket/manifest.jsonand no.socket/vendorledgers. The patch wiring is read straight from the project's root lockfiles and package-manager configs. This covers:A ledger record whose lockfile wiring is gone no longer attests, even under
--no-verify. That tightening is the breaking part.Also in this PR:
allow-remote=noneand refuses every hosted redirect (EALLOWREMOTE). The hosted run now writesallow-remote=allto the project.npmrcand warns. Explicit values are respected, there is an opt-out flag, and every reversal removes exactly what was added.Rebased onto #247: what adapted
The branch was squashed onto
09956d9and re-split by concern. The #247 contracts it now builds on:Manifest-free vendored mode. A vendored run writes no manifest, so the "manifest deleted" VEX cells are manifest-free by nature.
legacy-manifestcell: a record that a pre-5.0 vendored run left beside its ledger must attest the same way.--detachedtwins assert that neither spelling writes a manifest.not_applied.Embedded ledger records. Record resolution reads Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's ledger-embedded records (
detachedentries). The standalone manifest-drivenvendornow embeds itsrecordtoo, as a fallback copy. One ownership rule,commands::vendor_record_is_unowned, is shared byvex,listandsetup --check(fold_vendor_records, formerlyfold_detached_records).repairkeeps preferring a manifest that moved on to a newer uuid.detachedstill means "no manifest owner", so Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's manifest reconcile, legacy migration and get/scan idempotency are unchanged.Corrupt vendor ledger. For
vexonly,vendor_ledger_corrupt(exit 2, the ledger named and never rewritten) supersedes Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's disclose-then-manifest_not_foundposture.setup --checkkeeps Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247'swarn_unreadable_vendor_statepath.Lock window and residue.
vexnever takesapply.lock, never creates.socket/and never writes. The hosted.npmrcedit ridesrewrite.files/rewrite.edits, so it is written:The per-purl unwind flushes through Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's shared
staged::flush_staged. Suites that plant a stale ledger after a full rollback recreate.socket/first, and the hosted rollback suite checks thatvexdoes not recreate it.API and fs helpers. Record fetches use Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's uuid-only
ApiClient::fetch_patch.select_lockfileand the extractors read through the guardedutils::fsreaders.atomic_write_bytes_preserving_modestays inside Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247'scommit_stagestructure.Rewriters.
plan_cargo_lockkeeps Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's multi-source twin disambiguation (Ambiguous) and hoisted regexes. The v1[metadata]handling was layered on top of both.CLI wording. Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's no-manifest lines ("No patch manifest found; nothing to apply.", "No manifest found, nothing to vendor.") are kept. The bun workflow keeps Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's two modes (the vendored-detached leg is gone). The pdm backtest's refusal check follows the manifest-free footprint.
CHANGELOG. One [Unreleased] v5 section lists both PRs. Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's "vex discloses an unreadable ledger" bullet now points at the
vendor_ledger_corruptentry.Rebased onto #248: what adapted
The 7 commits were replayed onto
15a6ba6. Conflicts, per commit:scan/hosted.rs,tests/coverage_fix_scan_hosted_dryrun_vendored.rs). Both sides kept: the.npmrcplumbing and warnings sit beside Consolidated terminal UI and CLI-wide output polish #248'shuman_warnings/format_warningrendering. The dry-run detail drops its(--dry-run)marker ("allow-remote=allwould be written to a new project .npmrc"), following Consolidated terminal UI and CLI-wide output polish #248's pnpmtrustLockfiletwin: the summary line already says it is a dry run. Both new dry-run tests in the coverage file were kept. The--no-npm-allow-remote-configdoc and help heading follow Consolidated terminal UI and CLI-wide output polish #248'shelp_text_hygienerules.vex.rs,vendor.rs,scan/hosted.rs).vex.rswas rebuilt from Consolidated terminal UI and CLI-wide output polish #248's version with this branch's semantics on top.ui::pluralreplaces the branch's privateplural. Omissions use Consolidated terminal UI and CLI-wide output polish #248'sformat_omission_warning(Warning: omitting <purl> from VEX: <phrase> (<tag>)), with phrases for the new reasons. The manifest-lessapply --vex/vendor --vexlines go throughformat_vex_written/format_vex_dry_run_skip. Record fetches show aui::StatusLineprogress line. Manifest-lessvexhonours--dry-runand-O -. Thehosted.rsconflicts were comments only.e2e_vex.rs,covgap_commands_vex.rs). The omission assertions use Consolidated terminal UI and CLI-wide output polish #248's format. The corrupt-vendor-ledger tests keep this branch'svendor_ledger_corrupthard error.CLI_CONTRACT.md). Two paragraphs were merged word by word: Consolidated terminal UI and CLI-wide output polish #248's plurals plus this branch's embedded-record anddetachedtext. Consolidated terminal UI and CLI-wide output polish #248's CHANGELOG entries are intact.Shared readers: one lockfile traversal layer
Discovery and the lock inventory (
vendor::lock_inventory, which backs thescan/getsupplement, the vendored fetch inventory andrepair's recovery) read each lockfile format through ONE reader. That reader yields every entry, Socket-owned ones included. The inventory's registry views drop the Socket-owned entries, and discovery's extractors classify and validate them. Each consumer still chooses its own files and does its own I/O: discovery reads every present file through its recognizing ctx (rule 11), and the inventory keeps its precedence chains.lock_inventoryis now a directory module with one file per format. Each file has three parts: a pure entry model, a file-selection section that only stats files, and the registry view. Architecture tests enforce three things:lock_inventory::npm_lock_nodeslock_inventory::pnpm::pnpm_packagesover the hosted rewriter's pnpm grammar (every key generation, CRLF included),classify_pnpm_key,rush_lock_relslock_inventory::yarn::{classic_entries, berry_entries}. One berry locator (parse_berry_locator), one cache-key and checksum rule, and one multi-descriptor key splitter, shared by the hosted rewriter, the vendored berry backend and discoverylock_inventory::bun::bun_text_entriesover the backends' fail-closedvendor::bun_lock_textline grammar;BunLockb::parse_packages(also used bybun_lock's vendor paths and the trust anchor).cargo/config*cargo_lock::locked_packages.cargo_config's[patch]and[registries]walks and effective-config probe, which the writers read through toogo_mod_edit's read helpers (normalize_for_read,block_structure_error,hosted_module_uuid),go_sum_edit::go_sum_lines/is_h1_dirhashvendor::gemfile_lock, a new model covering sections, checksums, remotes and lock names.vendor::gem::gem_declaration_anyand discovery's source-block grammar, now also used for ledger livenesslock_inventory::composer_lock_packages. The composer writer's lock walks use its array index tooutils::python_lock(uv source fields, script-lock pairing),utils::poetry_lock,lock_inventory::pypi::parse_pipfile_lock,utils::hatch::dependency_specs.utils::requirements, a lexer lifted out of the vendored planner, now provides the exact-pin rule for the inventory, discovery and the planner. There is one hosted pypi URL grammar for the Pipfile.lock inventory and discoveryvendor::maven_pomandvendor::nuget_config;nuget_feed::nuget_lock_entries, shared by discovery and the feed writerutils::digest(SRI pin rule, hex digest shapes) andutils::purl's validating builders, shared by discovery, the inventory, ledger recovery and the rewritersDiscovery's own duplicates are gone as well.
DiscoverCtx::locateclassifies a lock location once for every extractor (vendored path, hosted uuid, decorated leaf). There is oneWiredtype, one set of vendor-dir predicates and one JSON / TOML parse-and-diagnose helper.Ledger liveness is one rule,
Discovery::{wires_package, vendor_entry_live, redirect_record_live}. Each call site holds it throughLedgerLiveness: the sorted redirect-ledger files, plus the lock inventory, loaded lazily and at most once.vexattestations.scan's takeover classification,hosted_wiring_retainedandredirectState.wiringLive.Cargo crates.io provenance is an explicit
LockfileEntry::source_kind; it is no longer inferred from the checksum variant. The CLI shares one purl splitter, one vendor-ledger lookup and one npm identity crawl acrossvex,scanandvendor.Integration round (after #248). The refactor's second pass removed the last parallel walkers that the duplication maps had found. There are 16 fixups, all folded into commits 4–9:
The same round moved the reason a patch was gated into
warnings[], so--jsonkeeps it (see "Behavior changes").Line counts
Production lines are non-blank lines with tests,
#[cfg(test)]items and golden harnesses excluded. "Before" is the pre-refactor head of this branch; "after" ise3d0ca9(commit 8).vex/discover/*vendor/lock_inventory(main: 2,262 in one file)vex_sources.rs+vex_consumed.rsmaven_pom,nuget_config,utils::digest)The refactor is not a net line reduction. Each format now has one traversal; the duplicated walkers are gone from discovery and the scanners.
lock_inventoryand the writer modules gained the entry models, which yield every entry kind rather than just the registry ones, plus their docs.Equivalence proof (golden snapshots)
Before any code moved, the refactor recorded golden snapshots on the pre-refactor tree:
vexCLI output (exit code, envelope and document) for every hermetic e2e call.Every later step had to keep them byte-identical. Old-vs-new differential copies of each consolidated function also ran during the work. Comparing the final tree against those baselines:
vexwarnings[]array (checked by deleting everywarningskey and comparing)The only behavioral change is intended. A hand re-indented
bun.lockused to be read by discovery's own JSONC parser, while every other command refused it. It is nowlockfile_unparseable, the same as everywhere else (reformatted_jsonc_lock_is_still_readbecamereformatted_lock_is_refused_like_every_other_reader). The CLIwarnings[]additions are the new gating-reason warnings. No existing test assertion was loosened.That scaffolding was about 460k lines of generated JSON, so it is not committed. Commit 9 keeps a compact regression pin instead: discovery output for the 182 committed fixture projects, one JSON file per fixture family (13 files, about 3.8k lines). It is regenerated with
SOCKET_PATCH_UPDATE_GOLDEN=1 cargo test -p socket-patch-core --lib vex::discover::testing::golden, and a fixture without an entry (or an entry without a fixture) fails.Left separate on purpose:
maven_repo/ redirect pom regexes, thenuget_feed/ redirect key harvesters,wired_vendor_integrity's line windows andvendored_entry_in_use. Moving them onto the shared readers changes writer behavior, so each needs its own commit with a reviewed golden diff (follow-up).Design
Discovery (core,
vex::discover/). It is read-only, never uses the network and never fails the run: a malformed file becomes a diagnostic. There is one extractor per PM family:bun.lock/bun.lockb);-r, Hatch / PEP 621 direct refs);The result is
Discovery { refs, diagnostics, recognized, unlocked_pins, elsewhere }. Every root file is read; there is no precedence chain, because the hosted rewriter edits every candidate it finds.Fail-closed validation. Every value is committed, tamperable data:
https://patch.socket.devor the configured--patch-server-urlorigin, with no userinfo. The uuid is the last canonical path segment, because grant tokens can be uuid-shaped..socket/vendor/<eco>/<uuid>/…whose leaf names the entry's own artifact.patched_ref_unattributable).UnlockedPin) can keep a ledger record live but never creates a ref.Record resolution (CLI,
vex_sources.rs). Sources are tried in order: manifest, redirect ledger, vendor-ledger embedded record, then (online only) the patch API by uuid. Fetches run 10 at a time withget's 401/403 → public-proxy fallback.socket-patch.vendor.jsonmarker is never a record.Evidence.
scan --mode hosted --vex.Liveness gates. These run before hashing and are still enforced under
--no-verify, which now skips only the hashing:vendor_unwired/redirect_unwired: the ledger record's lockfile wiring is gone. Discovery is authoritative for every uuid a read file mentions, so a rejected mention keeps nothing alive.wiring_conflict: the lockfiles wire one package to several patches.record_mismatch: the record names a different package or uuid.record_unavailable: offline, 404, refused or a transport error. The run continues.Product auto-detect. Adds go.mod, composer.json, pom.xml, a single
*.csprojand a single*.gemspec, after the existing probes.npm 12
.npmrcallow-remote auto-configThe decision was: fix the
.npmrcand warn; respect explicit values; add an opt-out flag; make it revertible.Trigger. A
scan --mode hosted/get --mode hostedrun that leaves a rootpackage-lock.json/npm-shrinkwrap.jsoncarrying a granted hosted artifact URL. The run then ensuresallow-remote=allin the project.npmrc:redirect_npmrc_allow_remote(created/added).redirect_npm_allow_remotewith the tradeoff:alladmits every url-resolved dependency tree-wide, while each entry's sha512 pin stays enforced.Explicit values are respected and named in the warning. Any explicit non-
allvalue in:.npmrc;@npmcli/configdoes;npm_config_allow_remoteenv var, which beats every.npmrc.A symlinked, unreadable or bare-CR
.npmrcis left alone, with a manual-remedy warning.Opt-out.
--no-npm-allow-remote-config/SOCKET_NO_NPM_ALLOW_REMOTE_CONFIG.Grammar. Follows npm's bundled
iniexactly, measured on npm 12.1.0 and cross-checked against ini 6.0.0 / 7.0.0:allow-remotecounts;[section]bodies are not top-level;Revertible. Every reversal removes exactly what was added, once no package-lock entry needs it:
NpmrcAllowRemoteinverse);rollback/remove/ the vendored takeover ("last one out", same transaction);A created file the user has since modified keeps the user's lines (
redirect_npmrc_allow_remote_modified, surfaced by rollback, remove, vendor and the reconcile). A symlinked.npmrcrefuses an unwind at plan time, before anything is written.Safety. Never written on
--dry-run; the dry run previews the write, including for a vendored → hosted takeover. Mode-preserving atomic writes create the stage with the destination's permission bits, so a 0600 token-bearing.npmrcis never staged world-readable.Output conventions
The human output this branch adds uses #248's mechanisms:
The omission line is Consolidated terminal UI and CLI-wide output polish #248's
Warning: omitting <purl> from VEX: <phrase> (<tag>), with phrases for the new reasons (record_unavailable,record_mismatch,vendor_unwired,redirect_unwired,wiring_conflict).Omissions are sorted by purl, so stderr and the skipped events are deterministic.
Plan notes are sorted, deduplicated and start with a capital letter.
Counts use
ui::plural. Record fetches show aui::StatusLine(Fetching patch records... (n/total)), which is silent under--json/--silent.Manifest-less VEX lines use Consolidated terminal UI and CLI-wide output polish #248's
format_vex_written/format_vex_dry_run_skip.The npm caveat prints as
Warning (redirect_npm_allow_remote): ….Failed VEX runs carry the discovery diagnostics into
warnings[](standalone, embedded and scan JSON envelopes). The reason a patch was gated is there too:vex_record_offline,vex_record_not_found,vex_record_fetch_failed;api_auth_fallback, the same text asget/scan;vex_wiring_conflict,vex_record_supersededandvex_claim_unwired.A failed embedded
--vexadds onevex_omittedper omitted patch to the host command'swarnings[], and--silentlists the omissions under the error.Per-PM × version support matrix
Every PM is supported in both hosted and vendored modes, except as noted. "Hermetic" means the wiremock-backed
e2e_vex_lockfile_<pm>suite in the defaulttestjob on all 3 OSes. "Real-PM" means the gated suites in CI'se2ematrix, the dedicated matrix jobs or the per-PM compatibility workflows; every real-PM flow ends in the manifest-less VEX matrix, with these cells:--offline→record_unavailablewith zero requests;--no-verify;legacy-manifestwhere vendored..npmrc; npm 6: fails closed,redirect_npm_legacy_client)resolutionsmapping).sha1required)packages.lock.jsonentry or an exclusive mapping)setup.manualonly)Cross-cutting suites:
e2e_vex_manifestless_embedded,e2e_vex_redirect,e2e_vex_vendor,vex_e2e_common_selftest, and the core polyglot test (a root with every PM discovers the union).Real-PM spot checks on the final code (before the whitespace-only fmt fixups and the test-only golden slimming; local macOS, all green):
e2e_redirect_npm_build,e2e_vendor_npm_build) 24/24The uv leg needs
SOCKET_PATCH_UV_E2E_PYTHONset to a Python ≥ 3.9. Without it, uv picked this machine's Python 3.8 andhosted_uv_export_pylock_manifestless_vexstopped at setup (pylock.tomlrequires>=3.9). That is an environment issue, not a product one.Earlier rounds (local macOS, all green): after the first refactor pass, the same eleven PMs. After the #248 rebase, npm 12.1.0 and pnpm 10.34.5. After the #247 rebase, npm 10.9.9 / 12.1.0, pnpm, both yarns, cargo, go, uv and bundler. Before the rebases, the full per-version matrices above were run per PM. At this HEAD they run in CI.
Behavior changes
--no-verify/--vex-no-verify. Those flags now skip only the hashing..socket/vendor/state.jsonisvendor_ledger_corruptforvex(exit 2; the host command fails under--vex).allow-remote=allto the project.npmrc(or respect and name an explicit value) and always warnredirect_npm_allow_remote. New flag--no-npm-allow-remote-config/SOCKET_NO_NPM_ALLOW_REMOTE_CONFIG. New ledger kindredirect_npmrc_allow_remoteand warningredirect_npmrc_allow_remote_modified. Commit the.npmrcwith the lock.record_unavailable,record_mismatch,vendor_unwired,redirect_unwired,wiring_conflict.lockfile_unreadable,lockfile_unparseable,patched_ref_invalid,patched_ref_unattributable,vex_record_offline,vex_record_not_found,vex_record_fetch_failed,vex_wiring_conflict,vex_record_superseded,vex_claim_unwired,vex_omitted; alsoapi_auth_fallbackonvex.Cargo.lock's[metadata]checksums now verify a crates.io fetch;requirements.txtis read as pip's logical lines;six==1.*) is not an exact version;http://origin or a path-prefixed origin stays inventoried;pnpm-lock.yamlis inventoried;poetry.lock/pdm.lock/Cargo.lockthat is not valid TOML contributes nothing.bun.lockislockfile_unparseable.vendor_override_conflict.scanliveness: a commented-out Gemfilesource … doblock no longer keeps a reverted record alive.manifest_not_found(exit 2) now means no manifest AND nothing wired.apply --vex/vendor --vexwithout a manifest now attest what the lockfiles and ledgers wire. A project with nothing wired keeps the calm exit 0 and removes a stale document.apply --checkand--dry-runnever generate.--global/--global-prefix, because it gates the ledgers read from--cwd.vendorembeds the patchrecordin every ledger entry.sourceblock that precedesdist; otherwise composer 1 / 2.2 silently installed the pristine commit from git. A hand-ordered source that can't be dropped warnsredirect_composer_source_kept.GEMsection in bundler's source order (frozen installs on bundler ≥ 4.0.19).Cargo.lock.vendor_npm_sibling_lock_unwired.redirect_npm_legacy_client.Limitations and follow-ups
$CARGO_HOMEor parent cargo configs;--offlinegivesrecord_unavailable.installed.jsonandCOMPOSER=-renamed locks;allow-remote=allis tree-wide, which is npm's granularity; the per-entry sha512 pins stay enforced. A user-levelallow-remote=noneis respected, so npm 12 then refuses the hosted install until the user changes it (the warning says so).--vexonget --mode hosted|vendored;Test evidence
Final local gate on
feat/vex-lockfile-inventory(HEADfaf9ed3) (macOS arm64,CARGO_INCREMENTAL=0). The branch is based onorigin/main=15a6ba6(re-fetched after the gate;mainhas not moved) and the tree is clean.cargo clippy --workspace --all-features -- -D warnings(CI's step)cargo clippy --workspace --all-features --all-targets -- -D warningscargo test --workspace --all-features --no-runcargo test --workspace --no-fail-fast(vexctl v0.3.0 on PATH,SOCKET_PATCH_GO_E2E_REQUIRED=1, like CI)coverage_fix_scan_hosted_dryrun_vendored,in_process_redirect_pipenv)main's own, untouched as the repo rules require--all-targets -D warningsclean;cargo test -p socket-patch-core4,570 passed, 0 failed;cargo test -p socket-patch-cli --no-fail-fast3,928 passed, 0 failed, 133 ignored (245 binaries)scripts/release-lint.sh --sync-onlynode --test npm/socket-patch/bin/socket-patch.test.mjs)python3 pypi/socket-patch/test_dispatch.py)python3 -B -m unittest discover -s scripts/tests--shell=sh scripts/install.sh, the release scripts, and the newscripts/{uv,yarn-berry,yarn-classic}-vex-matrix.shmain(pre-existingci.ymlshellcheck infos; one line number shifts)Not run locally, left to CI: the Linux and Windows
testlegs,test-release, coverage,e2e-docker,hosted-e2e(production credentials), and the full per-version matrices.How to review
The commits are meant to be read in order, oldest first. Each one builds on its own:
75128f4fix(core): hosted/vendored rewriter fixes found by the real-PM matrices. Seven independent rewriter bugs, each with a core regression test. It is small and has no VEX code, so it is a good warm-up.0c5d370feat(hosted): auto-configure npm 12 allow-remote in the project .npmrc. Start atcore/src/patch/redirect/npmrc.rs(the grammar, the plan and the unwind). Then readreplay.rs/takeover.rs, thencli/src/commands/scan/hosted.rsandremove.rs. Tests:tests/redirect_npm_allow_remote.rs.c8a97derefactor(core/vendor): split lock_inventory into per-format submodules. A verbatim move ofmain's file. Only imports, visibility, module docs and section banners change, andgit show --color-movedshows everything else as moved. It exists so that the next commit's inventory changes can be read per format.85dd900feat(core/vex): discover hosted and vendored patch references from lockfiles.core/src/vex/discover/mod.rs: the types, the orchestrator,DiscoverCtx::locate, contested locks,recognized, and the liveness rule withLedgerLiveness.npm.rsandpypi_locks.rsare the largest. Also readpatch::redirect::hosted_patch_uuid.vendor/lock_inventory/*, plusvendor/{gemfile_lock, maven_pom, nuget_config, cargo_config, go_mod_edit, go_sum_edit, yarn_berry_lock, yarn_classic_lock, bun_lock_text}.rsandutils/{digest, purl, requirements, python_lock, hatch}.rs.df672b6feat(vex): manifest-less VEX.cli/src/commands/vex_sources.rs: the record view, the API fetch and the gating-reason warnings.vex_consumed.rs: hosted evidence.vex.rs: the liveness gates and the output.apply.rs/vendor.rs/scan.vendor_record_is_unowned, the product probes, andscan/mod.rs'sclassify_overlap_takeover/hosted_wiring_retained_purls, which now use the core liveness rule throughcommands::discover_wiringandLedgerLiveness.a9796f2test(cli): the suites. Mostly mechanical. Worth reading:tests/vex_e2e_common/(the shared omission oracle) and one hermetic suite, for examplee2e_vex_lockfile_npm.rs.164f594ci: the matrices and backtest steps. Coversci.yml, the new npm / go / poetry compatibility workflows and thescripts/*-vex-matrix.shdrivers.e3d0ca9docs. TheCLI_CONTRACT.mdsections "Manifest-less VEX (lockfile discovery)" and "Additive warnings", the README, the CHANGELOG [Unreleased] section anddocs/testing/npm-compatibility.md.faf9ed3test(vex): golden snapshot of discovery over committed fixtures. The harness iscore/src/vex/discover/testing/golden.rs; the JSON undercore/tests/fixtures/vex-discover-golden/is generated, so skim it.🤖 Generated with Claude Code
Note
High Risk
Changes security-sensitive attestation rules, hosted npm install policy (.npmrc), and lockfile parsing used by scan/vex across every ecosystem; extensive CI coverage mitigates but the behavioral surface is large.
Overview
This is a v5 breaking release centered on manifest-less OpenVEX:
vex(and embedded--vexonapply/scan/vendor) can attest hosted and vendored patches by reading patch wiring from root lockfiles and configs, with records resolved from manifest, ledgers, or the API. Ledger liveness is tightened: redirect/vendor ledger entries attest only while a lockfile still wires that patch—even under--no-verify(hash-only skip)—and corrupt.socket/vendor/state.jsonbecomesvendor_ledger_corruptforvex.Hosted npm on npm 12 auto-writes
allow-remote=allto the project.npmrc(ledgered, revertible, opt-out via--no-npm-allow-remote-config), with grammar aligned to npm’siniand explicit user/env overrides respected.Core work adds
vex::discoverplus shared per-format lock readers (splitlock_inventory, unified liveness withscan). CLI addsvex_sources/vex_consumed, embeds patch records in allvendorledger entries, and fixes several hosted/vendored rewriters (composer git fallback, gem source order, cargo v1, yarn 4.0.x checksums, npm dual-lock).CI/docs expand massively: per-toolchain e2e matrices (uv, poetry, pdm, maven, dotnet, bundler eras, yarn/cargo/npm/go workflows), Docker vendor suites for pypi, and README/CHANGELOG/CLI contract updates for the new VEX and npm 12 behavior.
Reviewed by Cursor Bugbot for commit faf9ed3. Configure here.