Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version for release #66

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Bumped version for release #66

merged 1 commit into from
Apr 2, 2025

Conversation

dacoburn
Copy link
Collaborator

@dacoburn dacoburn commented Apr 2, 2025

Issue with creating a new repo and handling there being no full scan causing an error. Also, when there was no head full scan there were no results.

Root Cause

When switching to the new endpoint some of the logic for when not diffing were removed which caused a gap in detection.

Fix

  1. When creating a repo because it doesn't exist yet in the retry adding in logic to handle the no head scan
  2. removed a hardcoded variable that was forcing diff and then bypassing diff when no head full scan
  3. Added the logic back in for treating the results from the full scan as the diffed results
  4. Fixed the package creation from SBOM Artifact to include purl and package url

Public Changelog

  • Fixed CLI logic to correctly handle when there is no head full scan or the repo does not exist before the full scan is ran

@dacoburn dacoburn added the Product Changelog New features for the public changelog label Apr 2, 2025
@dacoburn dacoburn requested a review from a team as a code owner April 2, 2025 22:17
@dacoburn dacoburn requested review from mikolalysenko and jhiesey and removed request for a team April 2, 2025 22:17
Copy link

github-actions bot commented Apr 2, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.34.dev1

Docker image: socketdev/cli:pr-66

@obarrera obarrera self-requested a review April 2, 2025 22:20
@dacoburn dacoburn merged commit d6e97a4 into main Apr 2, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-repo-create branch April 2, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Changelog New features for the public changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants