Move getOrgFullScan to streamOrgFullScan and getOrgFullScanBuffered #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalton
force-pushed
the
main
branch
6 times, most recently
from
bc78346 to
3383127
Compare
jdalton
force-pushed
the
main
branch
2 times, most recently
from
2f7c8e9 to
9999b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getOrgFullScanis a bit of a misnomer, especially since the rest doesn't stream the data.I'm moving the method to
streamOrgFullScanand deprecating the old method.Additionally, adding a new method
getOrgFullScanBuffere, which should make the distinction clear and not risk a sort of rug pull.We deprecate the old method and in some major we can complete the swap, or just drop it and leave it like this.