Extend XBOS plug to include monitoring #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtfierro
requested changes
May 30, 2017
There was a problem hiding this comment.
Only change I have is to put the units under a key like we do on other interfaces (https://github.com/SoftwareDefinedBuildings/XBOS/blob/master/interfaces/xbos_temperature_sensor.yaml#L14)
|
why do we have an interface in non SI units. You are making me so sad. |
|
Hahah we should probably switch that soon. I've made a note of it #34 |
gtfierro
approved these changes
May 30, 2017
phgupta
pushed a commit
to phgupta/XBOS
that referenced
this pull request
Jun 20, 2019
…ert-32-20-update-dashboard-with-graphs Revert "Graphs on dashboard - Total and HVAC comparison"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review requested @gtfierro @jhkolb