This repository was archived by the owner on Jun 27, 2022. It is now read-only.
Add require JS. #36
Open
Add require JS. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clinkingdog is anyone planning on reviewing this? |
|
Yes, @pimterry is going to look at it when he has a second. (He said he wouldn't be able to look at it till this year, though, so it could well be a little while longer.) |
There was a problem hiding this comment.
Up to you, but some people prefer to use require path config to map jquery to the current jquery version, rather than having the exact filename with version number in here (and same goes for other libraries). Means you don't have to make a change to every file in your codebase if you upgrade your version. It's an easy change anyway, but it's a bit messy.
|
A few comments, but nothing big or structural. Otherwise looks good to me! Sorry for the delay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests all pass, but I haven't done a manual test of this yet.
resolves #8