feat: Add ASIO backend #36

geom3trik · 2025-03-17T18:59:46Z

Description

Adds ASIO backend.

Needs #31

Fixes #16

Type of Change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Performance improvement
Code cleanup or refactor

How Has This Been Tested?

Todo

Checklist:

My code follows the style guidelines of this project
I have made corresponding changes to the documentation
My changes generate no new warnings
Wherever possible, I have added tests that prove my fix is effective or that my feature works. For changes that
need to be validated manually (i.e. a new audio driver), use examples that can be run to easily validate them.
New and existing unit tests pass locally with my changes
I have checked my code and corrected any misspellings

Screenshots (if appropriate):

Additional Notes:

Add any additional notes about the PR here.

SolarLiner

Sorry I got too hasty reviewing this when it's still draft, but I thought I'd do it anyway and you can take the comments into account when you want

Cargo.toml

src/backends/asio/device.rs

src/backends/asio/mod.rs

src/backends/asio/prelude.rs

src/backends/mod.rs

SolarLiner

I'm gonna make a few new changes to the Duplex API branch to remove the DeviceType::Duplex enum since it's useless. I should have done it sooner and it made you do a bunch of extra work for it.

If you haven't rebased onto that branch yet, don't do it just yet; I'll ping you when I'm done

Cargo.toml

SolarLiner

I think it should be good now

geom3trik · 2025-03-30T13:21:29Z

I'm gonna make a few new changes to the Duplex API branch to remove the DeviceType::Duplex enum since it's useless. I should have done it sooner and it made you do a bunch of extra work for it.

Hmm okay, I was using that to return the default input and output device since on ASIO that could be a single duplex device.

SolarLiner

I think it's good now, you have the last suggestion to include and I think we can merge this sooner rather than later –- this way we can iterate over the Duplex API as a whole instead of having to juggle between all those PRs

geom3trik · 2025-04-16T22:51:01Z

I think it's good now, you have the last suggestion to include and I think we can merge this sooner rather than later –- this way we can iterate over the Duplex API as a whole instead of having to juggle between all those PRs

Yep I agree 👍 was waiting for this to merge before reviewing the duplex api pr. Should be able to finish this off in the next couple of days.

SolarLiner

LGTM (pending the couple of comments I made).

I think I'll want to make more changes to the general Duplex API (especially the StreamConfig I think I'll separate the input and output channels, it's a little bit of duplication but I think it'll be worth it).

SolarLiner · 2025-04-17T17:13:37Z

src/backends/asio/device.rs

+        let device_type = match (is_input, is_output) {
+            (true, true) => DeviceType::DUPLEX,
+            (true, false) => DeviceType::INPUT,
+            (false, true) => DeviceType::OUTPUT,
+            // todo
+            (false, false) => return Err(AsioError::BackendError(asio::AsioError::NoDrivers)),
+        };


I would also add DeviceType::PHYSICAL as a property for hardware devices

SolarLiner · 2025-04-17T17:15:29Z

src/backends/asio/device.rs

+        let buffer_size = match stream_config.buffer_size_range {
+            (Some(min), Some(max)) if min == max => Some(min as i32),
+
+            _ => None,
+        };


I think since we can control the exact buffer size, we should go with min or max.min(512) instead

Not sure I understand. I thought when min == max then the user has specified a specific buffer size.

Yes, however currently you're not respecting the conditions the user has provided in any other case (ex. (None, Some(128) or (Some(256), Some(1024)).

The expression I gate would translate in Rust as min.or(max).unwrap_or(512). But I since saw that the buffer size you pass to asio-sys is actually an Option, so you can remove the .unwrap_or part.

geom3trik force-pushed the asio-duplex branch from 6e4e417 to a3c0a32 Compare March 17, 2025 19:25

SolarLiner reviewed Mar 17, 2025

View reviewed changes

SolarLiner assigned geom3trik Mar 17, 2025

SolarLiner added feature New feature or request P-Windows Issues and PRs targetting Windows labels Mar 17, 2025

github-project-automation bot added this to Backlog Mar 17, 2025

github-project-automation bot moved this to Todo in Backlog Mar 17, 2025

SolarLiner added this to the 0.1.0 milestone Mar 17, 2025

SolarLiner linked an issue Mar 17, 2025 that may be closed by this pull request

Add ASIO driver #16

Open

SolarLiner moved this from Todo to In Progress in Backlog Mar 17, 2025

SolarLiner force-pushed the feat/duplex-api branch from 5cbf00c to 0b0da73 Compare March 28, 2025 19:36

geom3trik force-pushed the asio-duplex branch 2 times, most recently from b49e376 to 690ae2c Compare March 29, 2025 13:22

geom3trik marked this pull request as ready for review March 29, 2025 14:08

geom3trik requested a review from SolarLiner March 29, 2025 14:08

SolarLiner requested changes Mar 29, 2025

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

SolarLiner reviewed Mar 29, 2025

View reviewed changes

geom3trik force-pushed the asio-duplex branch from de7816f to 925fa0d Compare March 30, 2025 13:02

SolarLiner force-pushed the feat/duplex-api branch from 305b8d1 to 7817f13 Compare April 4, 2025 09:21

geom3trik force-pushed the asio-duplex branch 2 times, most recently from 925fa0d to 375e531 Compare April 16, 2025 13:12

SolarLiner approved these changes Apr 16, 2025

View reviewed changes

github-project-automation bot moved this from In Progress to Can be merged in Backlog Apr 16, 2025

geom3trik force-pushed the asio-duplex branch from 375e531 to 375aef1 Compare April 17, 2025 13:15

geom3trik added 4 commits April 17, 2025 14:30

Update WASAPI backend for new API

225b460

feat: Add ASIO backend

14dcc52

Implement duplex stream

832b493

Add timestamps

ecf1e31

Enumerate Configs + Cleanup

2ddddc7

geom3trik force-pushed the asio-duplex branch from 375aef1 to 2ddddc7 Compare April 17, 2025 13:30

Update ASIO backend for new DeviceType bitflag

b68d6e1

geom3trik requested a review from SolarLiner April 17, 2025 14:22

SolarLiner approved these changes Apr 17, 2025

View reviewed changes

feat: Add ASIO backend #36

Are you sure you want to change the base?

feat: Add ASIO backend #36

Uh oh!

Conversation

geom3trik commented Mar 17, 2025 • edited by SolarLiner Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

How Has This Been Tested?

Checklist:

Screenshots (if appropriate):

Additional Notes:

Uh oh!

SolarLiner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SolarLiner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SolarLiner left a comment

Choose a reason for hiding this comment

Uh oh!

geom3trik commented Mar 30, 2025

Uh oh!

SolarLiner left a comment

Choose a reason for hiding this comment

Uh oh!

geom3trik commented Apr 16, 2025

Uh oh!

SolarLiner left a comment

Choose a reason for hiding this comment

Uh oh!

SolarLiner Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

SolarLiner Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

geom3trik Apr 20, 2025

Choose a reason for hiding this comment

Uh oh!

SolarLiner Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

geom3trik commented Mar 17, 2025 •

edited by SolarLiner

Loading