Add drawPngFromBuffer #210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjtwomey
force-pushed
the
draw-from-png-buf
branch
from
3aedfaf to
aa6ee82
Compare
chrisjtwomey
force-pushed
the
draw-from-png-buf
branch
from
e9302da to
aa6ee82
Compare
|
Thanks, this is great -- I was looking for this function. Any way we can get this merged so it's easier to use? |
stefanthoss
reviewed
Jan 24, 2025
Comment on lines
+265
to
+266
| if (!buf) | ||
| return 0; |
There was a problem hiding this comment.
Duplicate code, it's already defined further down.
There was a problem hiding this comment.
I'll fix this up if the maintainers ever consider merging this. Personally I don't see why not but looks like they haven't merged any PRs from non-SolderedElectronics members in years...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the library has methods to draw bmp and jpg from buffer but not png, so I added it.
Tried it on my Inkplate10 (v1) and behaves identically to
drawPngFromWebPersonally I need a function like this as I download png data using a custom function (need to also read HTTP headers) and needed a way to write to the display without drawing again from a URL or SD card.