レビューお願い致します #11
Open
レビューお願い致します #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
コードのアピールポイント
簡潔に実装するための規則探しに苦労しました．（特にromanizeメソッド）
deromanizeメソッドのロジックはromanizeメソッドと比較してシンプルにできたかなと思います．
コードを書くのにかかった時間
2~3時間
だいたいのプログラミング歴
大学の授業含めると約6年．自主的に調べたり手動かすようになってからは約3年．
実際に解いてみた感想
Rubyの文法や独特な書き方に慣れていないことを痛感しました．
エレガントな実装を模索しましたが，パワーで解決する方法しか思いつきませんでした．悔しい，，，
伊藤さんにメッセージ
チェリー本と伊藤さんの記事には大変お世話になっております．
ボコボコにレビューしてください．