Skip to content

Fix issue with drag and drop index positioning #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue with drag and drop index positioning #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8624d21
Update knockout-sortable.js
jfrei Jul 13, 2016
28c1e0f
Update knockout-sortable.js
jfrei Jul 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion knockout-sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@
// drop an item above the 3rd visible item, but the 2nd visible item
// has an actual index of 5.
if (e.item.previousElementSibling) {
newIndex = to().indexOf(ko.dataFor(e.item.previousElementSibling)) + 1;
newIndex = to().indexOf(ko.dataFor(e.item.previousElementSibling));
newIndex += (newIndex > originalIndex ? 0 : 1);
}

// Remove sortables "unbound" element
Expand Down