Extracting proxy role and preparing for CDK#47
Draft
citizen-stig wants to merge 11 commits intomainfrom
Draft
Conversation
Member
Author
| # ============================================================================= | ||
| # SSL Certificate Acquisition | ||
| # ============================================================================= | ||
| - name: Build certbot domain arguments |
Member
There was a problem hiding this comment.
Sorry, I know we're tracking a moving target here - but we'll need to add the s3 fetch and sync logic from https://github.com/Sovereign-Labs/sov-rollup-cdk-starter/pull/50
Member
Author
There was a problem hiding this comment.
Yep, I will convert this PR to draft.
Member
preston-evans98
left a comment
There was a problem hiding this comment.
Looks good to me, other than needing support for the zero-downtime proxy replacement changes that just merged into CDK.
I assume you've tested this out with a personal CDK deploy already. If not, that's probably worth doing before merging as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Following params can be present in
runtime_varsfor proxy:Adds https://docs.influxdata.com/telegraf/v1/input-plugins/nginx/ inputs