Add support for Chain Hash Overrides. Fix minor bugs#64
Open
preston-evans98 wants to merge 3 commits intomainfrom
Open
Add support for Chain Hash Overrides. Fix minor bugs#64preston-evans98 wants to merge 3 commits intomainfrom
preston-evans98 wants to merge 3 commits intomainfrom
Conversation
theodorebugnet
approved these changes
Feb 12, 2026
| repo: "{{ ansible_repo_url }}" | ||
| dest: "{{ ansible_checkout_dir }}" | ||
| version: "main" | ||
| version: "{{ version_spec.rollup_versions[0].ansible_commit }}" |
Contributor
There was a problem hiding this comment.
Note that in build_single_version.yaml, for each version we checkout that version's commit, so the version checked out after the clone here is a no-op - what matters is the version we set in the version_spec fact. Looking back, maybe the version shouldn't be specified at all here to avoid confusion.
But other than clarity, this change is of course not harmful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for chain hash overrides. It also fixes two minor bugs:
admin_addresseson the sequencer, which means that some valid callmessages from private keys we control are rejected by the sequencer as unauthorized. This PR fixes the issue.