Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the results of the v2 compliance checks. #379

Closed
wants to merge 2 commits into from

Conversation

garloff
Copy link
Member

@garloff garloff commented Nov 11, 2023

v1 is out of business sinve Nov 1, 2023, so let's not display v1 information any longer. v2 is valid for another month, which is when we will require v3 (unless we decide on extending v2 validity). Main challenge is that v3 flavors require the two flavors with local SSDs (and that we dropped the requirement for all other flavors with local disks).

v1 is out of business sinve Nov 1, 2023, so let's not display v1 information
any longer. v2 is valid for another month, which is when we will require v3
(unless we decide on extending v2 validity). Main challenge is that v3 flavors
require the two flavors with local SSDs (and that we dropped the requirement
for all other flavors with local disks).

Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Copy link
Member Author

garloff commented Nov 11, 2023

@frosty-geek - we need to approve this soon to follow our own rules.
This is not good for PlusServer however:

  • Prod1 does currently pass image-md check and flavors-names v1, but not v2 (new flavor names missing) and v3 (new flavor names missing and new SSD flavors not present)
  • Same for Prod2 (though there is an extra warning that VyOS image_source metadata should contain a URL but does not)
  • Prod3 does not pass image metadata (see issue [BUG] Compliance checks fail for all clouds in main branch #479), but passes flavor-name check v1 and v2 -- the new names exist (in addition to the old ones). It does not pass v3, as the SSD flavors are missing.
  • gx-scs passes image-md and flavors v1 and v2 (but not v3: no SSD flavors)

This means all three Prod units turn red, only gx-scs staying green.
Fixing #479 (a no brainer) would turn Prod3 green.
But in a month, all of them turn red again, as we lack the SSD flavors in all regions.

IMVHO, we need to:

  • Address [BUG] Compliance checks fail for all clouds in main branch #479 quickly (should be a no-brainer -- just add the metadata, this has zero negative impact)
  • Find a way for Prod1 and Prod2 to quickly pass at least v2 flavor check.
    If you need us to build a task force to support with painless flavor renaming, let me know. After some work on the CiaB system, I am convinced the the least painful way to do it is to just rename the flavors (database operation) and provided compat name alias support to appease customer's automation referencing the old names.
  • Understand your timeline to implement flavors with local SSDs (required for v3 flavor compliance)
  • Possibly do minor (!!!) adjustments to the standards validity dates to bridge a few weeks gap. (Note: I can not do major adjustments without causing also major damage to the credibility of our standardization, something that neither PlusServer, nor SCS nor our other partners can want.)

@garloff garloff requested a review from fkr December 14, 2023 09:49
@mbuechse
Copy link
Contributor

@frosty-geek @fkr @garloff This seems important. How do we proceed?

@mbuechse
Copy link
Contributor

I'm pretty sure this is obsolete by now.

@mbuechse mbuechse closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants