Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept private image_source as set in the standard. #411

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

garloff
Copy link
Member

@garloff garloff commented Dec 18, 2023

We do produce an info if verbose mode -v is used, as this is of course not desirable, so it's worth a note.

We do produce an info if verbose mode -v is used, as this is of
course not desirable, so it's worth a note.

Signed-off-by: Kurt Garloff <[email protected]>
@garloff garloff added IaaS Issues or pull requests relevant for Team1: IaaS standards Issues / ADR / pull requests relevant for standardization & certification labels Dec 18, 2023
@garloff
Copy link
Member Author

garloff commented Dec 18, 2023

This caused trouble with the VyOS 1.4 rolling 20221121 image on PCO (prod1, prod2) which has the image_source value set to private.
While not preferred, it's legit according to scs-0102-v1, so we have to accept it.

Copy link
Member

@fkr fkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think doing grammar / spelling fixes should be a separate commit from a change that changes the logic (since when backing out the functional change also spelling and grammar fixes are lost).

@garloff
Copy link
Member Author

garloff commented Dec 18, 2023

Right.
I do see these things when I look at the code and can't stop myself from fixing.
You are absolutely right, they should be in a different commit.
For larger changes, I'm more disciplined, but I have to admit that I tend to do these smaller fixes along the way as it saves me some time. Sorry for that!

@garloff garloff merged commit 63b61de into main Dec 18, 2023
3 checks passed
@garloff garloff deleted the fix/image-md-allow-private-source branch December 18, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IaaS Issues or pull requests relevant for Team1: IaaS standards Issues / ADR / pull requests relevant for standardization & certification
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants